Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44695: Add signature copy and verification support when working with local Quay registry #4426

Merged
merged 14 commits into from
Jan 21, 2025
Merged

OCPBUGS-44695: Add signature copy and verification support when working with local Quay registry #4426

merged 14 commits into from
Jan 21, 2025

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 17, 2025 •
edited
Loading

This is the last implementation stage of signature verification support by MicroShift CI when using local Quay registry. The previous work includes #4402 and #4413

This PR is tightly coupled with #4430 in 4.18 branch where the actual verification takes place.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash ggiguash changed the title Add signature OCPBUGS-44695: Add signature copy and verification support when working with local Quay registry Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 17, 2025
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is the last implementation stage of signature verification support by MicroShift CI when using local Quay registry. The previous work includes #4402 and #4413

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jogeo January 17, 2025 09:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@ggiguash ggiguash mentioned this pull request Jan 19, 2025
Merged
@ggiguash
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2025

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm

@ggiguash
Copy link
Contributor Author

/test verify

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

This is the last implementation stage of signature verification support by MicroShift CI when using local Quay registry. The previous work includes #4402 and #4413

This PR is tightly coupled with #4430 in 4.18 branch where the actual verification takes place.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as ready for review January 20, 2025 11:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pacevedom
pacevedom approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7bde43 into openshift:main Jan 21, 2025
13 checks passed
@openshift-ci-robot
Copy link

@ggiguash: Jira Issue OCPBUGS-44695: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44695 has been moved to the MODIFIED state.

In response to this:

This is the last implementation stage of signature verification support by MicroShift CI when using local Quay registry. The previous work includes #4402 and #4413

This PR is tightly coupled with #4430 in 4.18 branch where the actual verification takes place.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash deleted the quay_sigstore branch January 21, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@jogeo jogeo Awaiting requested review from jogeo

@dhensel-rh dhensel-rh Awaiting requested review from dhensel-rh

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pacevedom