Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] OCPBUGS-48577: Enable sigstore-based verification in MicroShift CI #4430

Merged

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 19, 2025

This is a manual cherry-pick of the following PRs:

Note that the last PR in the main branch is still open. This is because we can only test the signatures in z-stream branches where all container images are signed.

So, to complete this work, we need to show that the system is fully functional in 4.18 branch before merging any final changes to main.

In the main branch, the signature check will be disabled because not all the MicroShift and Red Hat container images are signed.

NOTES TO REVIEWERS

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2025
Copy link
Contributor

openshift-ci bot commented Jan 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2025
@ggiguash ggiguash changed the title Quay sigstore 4.18 [release-4.18] OCPBUGS-48577: Enable sigstore-based verification in MicroShift CI Jan 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2025
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test verify

@ggiguash ggiguash marked this pull request as ready for review January 20, 2025 09:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@ggiguash
Copy link
Contributor Author

/test ?

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test images
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-arm
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-periodic
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-release-4.18-images
pull-ci-openshift-microshift-release-4.18-security
pull-ci-openshift-microshift-release-4.18-test-unit
pull-ci-openshift-microshift-release-4.18-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests security test-unit verify

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

/label backport-risk-assessed
/label cherry-pick-approved
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 21, 2025
@ggiguash
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 21, 2025
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-48577, which is invalid:

  • expected dependent Jira Issue OCPBUGS-44695 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-48577, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-44695 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-44695 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jogeo January 21, 2025 14:30
@openshift-merge-bot openshift-merge-bot bot merged commit 79dd76a into openshift:release-4.18 Jan 21, 2025
13 checks passed
@openshift-ci-robot
Copy link

@ggiguash: Jira Issue OCPBUGS-48577 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of the following PRs:

Note that the last PR in the main branch is still open. This is because we can only test the signatures in z-stream branches where all container images are signed.

So, to complete this work, we need to show that the system is fully functional in 4.18 branch before merging any final changes to main.

In the main branch, the signature check will be disabled because not all the MicroShift and Red Hat container images are signed.

NOTES TO REVIEWERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash deleted the quay_sigstore_4.18 branch January 21, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants