validation: Remove runc 'create' exit timing crutches #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
create-exit-timing
branch
from
b3453b3 to
0291a97
Compare
Member
|
LGTM |
1 similar comment
|
LGTM |
|
@wking need rebase. |
The runtime-spec defines a 'creating' status [1] and requires the 'create' operation to finish creating the container [2,3]. Our command line API also requires the 'create' command to block until creation completes: Callers MAY block on this command's successful exit to trigger post-create activity. runc does not support 'creating' yet [4], and it seems to return from 'create' before having quite finished (or we wouldn't have needed the code I'm removing in this commit). However, both of those are runc problems. These tests are about validating spec compliance, not about working around runc's issues, so remove the crutches. [1]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/runtime.md#L19 [2]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/runtime.md#L54 [3]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/runtime.md#L101 [4]: opencontainers#557 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
create-exit-timing
branch
from
0291a97 to
c76062f
Compare
Member
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime-spec defines a
creatingstatus and requires thecreateoperation to finish creating the container. Our command line API also requires thecreatecommand to block until creation completes:runc does not support
creatingyet, and it seems to return fromcreatebefore having quite finished (or we wouldn't have needed the code I'm removing in this pull request). However, both of those are runc problems. These tests are about validating spec compliance, not about working around runc's issues, so remove the crutches.I've opened opencontainers/runc#1703 and opencontainers/runc#1704 on the path to fixing both of these issues upstream in runc, but I don't think we need to wait for those to land before dropping the workarounds here.