-
Notifications
You must be signed in to change notification settings - Fork 159
add 'state' test; using WaitingForStatus in insideValidation #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
6d78ff1 to
778691f
Compare
validation/util/test.go
Outdated
| PostCreate func(runtime *Runtime) error | ||
| PreDelete func(runtime *Runtime) error | ||
| PostDelete func(runtime *Runtime) error | ||
| PreCreate func(runtime *Runtime) ([]byte, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not assume that these functions will include something that has a stderr. Can we use *ExitError instead, and have the test include that stderr in their YAML diagnostic if the error casts to *ExitError? I'll work up a PR with that narrow pivot to help show what I'm suggesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work up a PR with that narrow pivot to help show what I'm suggesting.
Filed as #564.
bb65534 to
6e50906
Compare
6e50906 to
7843139
Compare
|
need to rebase after #563 |
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
7843139 to
696b805
Compare
|
Updated. PTAL @wking @Mashimiao @q384566678 |
Signed-off-by: Liang Chenye liangchenye@huawei.com