Skip to content

validation: Remove runc 'create' exit timing crutches #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouhao3 merged 1 commit into from
Jan 30, 2018
Merged

validation: Remove runc 'create' exit timing crutches #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions validation/pidfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"os"
"path/filepath"
"strconv"
"time"

tap "github.com/mndrix/tap-go"
"github.com/opencontainers/runtime-tools/validation/util"
Expand Down Expand Up @@ -47,9 +46,6 @@ func main() {
}
return nil
},
PreDelete: func(r *util.Runtime) error {
return util.WaitingForStatus(*r, util.LifecycleStatusCreated, time.Second*10, time.Second*1)
},
}

g := util.GetDefaultGenerator()
Expand Down
5 changes: 0 additions & 5 deletions validation/util/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,6 @@ func RuntimeInsideValidate(g *generate.Generator, f PreFunc) (err error) {
return err
}

// FIXME: why do we need this? Without a sleep here, I get:
// failed to start the container
// container "..." does not exist
time.Sleep(1 * time.Second)

err = r.Start()
if err != nil {
os.Stderr.WriteString("failed to start the container\n")
Expand Down