Repository navigation
build(deps): refresh compatible dependencies and patch Undici - #87
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 30, 2026, 12:50 AM ET / 04:50 UTC (Revision 20). ClawSweeper reviewWhat this changesUpdates workspace dependencies and pinned GitHub Actions, with pnpm overrides that resolve patched Undici and Sharp versions for Krillswitch’s builds and tooling. Merge readiness⛔ Blocked before merge - 3 items remain Current main still locks the older Undici and Sharp versions, while this PR resolves the patched versions. The overlapping Dependabot PRs closed unmerged, so this remains the viable patch. No concrete correctness or supply-chain defect was found; required code-owner approval is pending. Priority: P2 Review scores
Verification
How this fits togetherWorkspace manifests and pnpm choose dependencies for the Worker, dashboard, CLI, and SDK builds. CI and release workflows install that lockfile, then test, build, scan, deploy, or publish the resulting artifacts. flowchart LR
A[Workspace manifests] --> B[pnpm overrides]
B --> C[Resolved lockfile]
C --> D[Worker and dashboard builds]
C --> E[SDK and CLI builds]
F[Pinned GitHub Actions] --> G[CI and release jobs]
D --> G
E --> G
Decision needed
Why: The new pins match official tags, but PR CI cannot execute the tag-only release or Pages deployment effects, and code-owner approval is pending. Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the major-bounded Undici overrides until upstream exact pins advance, retain the matched auth generator, and verify the first Pages and SDK release runs after approval. Do we have a high-confidence way to reproduce the issue? Not applicable as a dependency update. Current main’s lockfile and the failed Dependabot run establish why the patched resolution is needed. Is this the best way to solve the issue? Yes. The bounded overrides repair the vulnerable transitive resolutions while retaining the declared Node floor and aligning the auth schema generator with its runtime dependency. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4e172a04b056. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (19 earlier review cycles; latest 8 shown)
|
0a0649f to
a8bcbf1
Compare
What Problem This Solves
Dependabot cannot apply the Undici security updates because Miniflare pins vulnerable Undici 7.29.0. This refreshes compatible dependencies and repairs that resolution, alongside the existing Sharp/libheif security fix.
User Impact
Development and deployment tooling use patched Undici 7.29.1/8.10.2 and Sharp 0.35.4. The declared Node >=22.22.0 floor, React 18/19 SDK peer contract, application and SDK versions, and database schema stay unchanged.
Why This Change Was Made
Add bounded Undici overrides alongside the existing security overrides, and refresh compatible runtime, build/test, and SHA-pinned Actions dependencies. This includes pnpm 11.28.0, Hono 4.13.9, React Query 5.104.0, Vite 8.3.1, Wrangler 4.142.0, and Cloudflare's Vitest plugin 1.3.0. Both dependency resolvers retain the two-day release cooldown.
Consolidates #106, #112, and #113. Better Auth stays at 1.6.33 with a matching schema generator; its 1.7 identity/schema changes remain deferred. jsdom 30 raises the Node floor, Vitest 5 conflicts with the Cloudflare plugin's Vitest 4 peers, and keyring 2 needs native credential-store upgrade proof. Those major bumps remain outside this change.
Evidence
The failing Dependabot run reports
security_update_not_possible: latest resolvable Undici 7.29.0, earliest fixed 7.29.1 (run). The regenerated lockfile now resolves patched Undici versions in both major lines, and the audit reports no known vulnerabilities.The final AWS Crabbox gate passed on Node 24.19.0 and pnpm 11.28.0: frozen install, lint, typecheck, all 252 tests (6 script, 37 core, 33 React, 48 CLI, 128 Worker), dashboard/demo/CLI builds, docs build, and packed SDK runtime/type entry-point verification. Auth-schema regeneration was byte-for-byte unchanged, and the Worker deployment dry run passed. Local actionlint also passed.
Lint retains 14 warnings in unchanged dashboard CSS, and the Worker tests print non-failing diagnostics from the synthetic webhook fixture. No assertions or checks were weakened, and no live deployment or release was performed.
Independent Codex review completed through P2 with no accepted findings. Its one cooldown finding was rejected against npm's publication timestamp: Workers Types 5.20260928.1 was published at 2026-09-28 01:30 UTC and verified at 2026-09-30 04:38 UTC, over 51 hours later. Frozen installs also passed pnpm's 48-hour policy checks.
The required code-owner approval is still pending; this PR is not merged.
Exact-head verification for
2fc418edb3e3d0e5f9e6138505e93abb094ae8fe: CI passed and CodeQL passed. All required checks are green; no CI rerun was needed. @vincentkoc and the maintainer/security owner teams have been requested for the required review.