Repository navigation
build(deps-dev): bump jsdom from 29.1.1 to 30.1.1 - #117
dependabot[bot] wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 6, 2026, 7:47 AM ET / 11:47 UTC (Revision 3). ClawSweeper reviewWhat this changesUpdates the React SDK’s simulated browser test environment to jsdom 30.1.1 and refreshes the dependency lockfile. Merge readiness⛔ Blocked before merge - 4 items remain The prior Node compatibility finding remains unresolved. Current main still uses jsdom 29.1.1 for React tests, so this upgrade remains distinct and cannot close as implemented. Priority: P2 Review scores
Verification
How this fits togetherThe React SDK supplies feature-flag hooks and server evaluation helpers. Its tests use jsdom to simulate browser rendering and storage; this dependency change affects repository development and testing. flowchart LR
A[Node runtime] --> B[Dependency installation]
C[Locked jsdom version] --> B
B --> D[Simulated browser]
E[React SDK tests] --> D
D --> F[Test results]
Decision needed
Why: The merged dependency refresh explicitly preserved the existing floor; changing that promise requires an intentional compatibility decision. Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the React test environment compatible with the declared Node contract until a separately approved runtime-support update validates installation and tests at the new minimum. Do we have a high-confidence way to reproduce the issue? Yes, source establishes the engine-contract mismatch: Node 22.22.0 satisfies the repository requirement but fails jsdom 30.1.1’s requirement. Installation and runtime failure were not executed in this read-only review. Is this the best way to solve the issue? No, the unconditional major upgrade conflicts with the declared runtime contract. Retaining the compatible dependency is safer until a coordinated support update is approved. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7be7204292c9. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.1.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.1.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
df93119 to
40be9b9
Compare
|
Thanks for the update. Closing this major upgrade to preserve the documented Node.js floor. jsdom 30.1.1 requires |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps jsdom from 29.1.1 to 30.1.1.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
0a117f430.1.1103f67dRemove unnecessary window cleanup from API testscdda00aTest HTTP/2 document and subresource loading7ab92ceUpdate@asamuzakjp/dom-selectorto v9.2.1d940c20Share jsdom settings across descendant windows6ba40cbFix and simplify option propagation3b3be70Preserve CSS priorities across declaration updates97b2758Align focusing and unfocusing with HTMLb7b460bUpdate w3c-xmlserializer to v671d562fUpdate html-encoding-sniffer to v7