Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,21 @@ Building libvfio-user

Build requirements:

* `meson` (v0.53.0 or above)
* `meson` (v0.57.0 or above)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this is necessary in a bit more detail please?
This is past the meson version in centos 7

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlevon I am seeing warnings when I build on Ubtuntu because the meson.build file seems to be using features not present in 0.53.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks & sorry for the slow response.

I did a bit of testing, and while meson does complain, this doesn't actually affect a normal build of the library on centos 7. So, overall, I'd prefer to keep running on that and just suck up the warning. Sound OK?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlevon based on this I will close this PR now. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for contributing!

* `apt install libjson-c-dev libcmocka-dev` or
* `yum install json-c-devel libcmocka-devel`

The kernel headers are necessary because VFIO structs and defines are reused.

To build:

To build the vfio-user library and examples:
```
meson build
meson setup build
ninja -C build
```
To install libvfio-user dynamic library and header files:
```
sudo ninja -C build install
```

Finally build your program and link with `libvfio-user.so`.

Expand Down
2 changes: 1 addition & 1 deletion meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ project(
'c',
version: '0.0.1',
license: 'BSD-3-Clause',
meson_version: '>= 0.53.0',
meson_version: '>= 0.57.0',
default_options: [
'buildtype=debug',
'c_std=gnu99',
Expand Down
Loading