Skip to content

Conversation

@sbates130272
Copy link

Update the top-level README.md to provide clear instructions on how to build and install libvfio-user. Also fix an issue in meson.build caused by an incorrect minimum version check.

Update the top-level README.md to provide clear instructions on how to
build and install libvfio-user. Also fix an issue in meson.build
caused by an incorrect minimum version check.

Signed-off-by: Stephen Bates <[email protected]>
Copy link
Collaborator

@jlevon jlevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Build requirements:

* `meson` (v0.53.0 or above)
* `meson` (v0.57.0 or above)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this is necessary in a bit more detail please?
This is past the meson version in centos 7

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlevon I am seeing warnings when I build on Ubtuntu because the meson.build file seems to be using features not present in 0.53.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks & sorry for the slow response.

I did a bit of testing, and while meson does complain, this doesn't actually affect a normal build of the library on centos 7. So, overall, I'd prefer to keep running on that and just suck up the warning. Sound OK?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlevon based on this I will close this PR now. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for contributing!

@sbates130272
Copy link
Author

sbates130272 commented Oct 20, 2025

@jlevon this is the warning I get when I do a meson build on Ubuntu 24.04. I would like to avoid this warning by bumping the minimum version in the meson.build file. Or alternatively we suppress this warning? I acknowledge this change causes issues on some distros due to the packaged version of meson being old.

WARNING: Project specifies a minimum meson_version '>= 0.53.0' but uses features which were added in newer versions:
 * 0.57.0: {'exclude_suites arg in add_test_setup'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants