-
Notifications
You must be signed in to change notification settings - Fork 58
build: Update the build and install instructions #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the top-level README.md to provide clear instructions on how to build and install libvfio-user. Also fix an issue in meson.build caused by an incorrect minimum version check. Signed-off-by: Stephen Bates <[email protected]>
jlevon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
| Build requirements: | ||
|
|
||
| * `meson` (v0.53.0 or above) | ||
| * `meson` (v0.57.0 or above) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why this is necessary in a bit more detail please?
This is past the meson version in centos 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlevon I am seeing warnings when I build on Ubtuntu because the meson.build file seems to be using features not present in 0.53.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks & sorry for the slow response.
I did a bit of testing, and while meson does complain, this doesn't actually affect a normal build of the library on centos 7. So, overall, I'd prefer to keep running on that and just suck up the warning. Sound OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlevon based on this I will close this PR now. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for contributing!
|
@jlevon this is the warning I get when I do a |
Update the top-level README.md to provide clear instructions on how to build and install libvfio-user. Also fix an issue in meson.build caused by an incorrect minimum version check.