Repository navigation
⚡ Select assertion-free LLVM SDKs (Phase 1) - #255
Merged
Merged
Conversation
burgholzer
added
continuous integration
This was referenced Sep 8, 2026
Open
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 88.71% 88.44% -0.28%
==========================================
Files 7 7
Lines 390 398 +8
Branches 94 100 +6
==========================================
+ Hits 346 352 +6
- Misses 44 46 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
burgholzer
force-pushed
the
codex/optimized-release-toolchain
branch
2 times, most recently
from
September 12, 2026 13:35
17104a9 to
0196974
Compare
Select the companion archive explicitly and isolate its tool cache. Keep the default manifest format and assertion-enabled behavior compatible with existing consumers. SDK publication precedes manifest updates. Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/optimized-release-toolchain
branch
from
October 5, 2026 11:48
9750652 to
86b9550
Compare
burgholzer
changed the title
This was referenced Oct 5, 2026
Keep the published version manifest unchanged until the SDK is released. Assisted-by: GPT-6 via Codex
Index LLVM 23.1.2 from release 2026.10.06 and exercise both assertion variants on every supported platform. Allow standalone installers to pin their manifest alongside the script so downstream PRs work before this manifest reaches main. Assisted-by: GPT-6 via Codex
Read the manifest beside the installers in a checkout or source archive, so PR tests use their own revision without a manifest URL override. Keep main as the fallback for standalone and piped installers. Exercise both paths in the existing installer matrix. Assisted-by: GPT-6 via Codex
Record published assertion-free companions as optional fields on existing entries. Resolve URLs directly and share target decoding in the generator. Keep checkout-local manifests and fail unavailable variants before downloads. Consolidate integration coverage, sample historical SDKs in CI, and use LLVM 22.1.8 for the 22 series. Document current installation requirements. Assisted-by: GPT-6 via Codex
Create the isolated SDK cache under RUNNER_TEMP. Ubuntu 26.04 mounts /tmp as a quota-limited tmpfs, which cannot hold extraction and cache copies. Assisted-by: GPT-6 via Codex
Align the action input description and all README usage examples with the published SDK version. Assisted-by: GPT-6 via Codex
Member
Author
|
This feels ready and a clear simplification of the action as well as the installer scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Install LLVM 23.1.2 from SDK release 2026.10.06 with
assertions: false, Bash-a OFF, or PowerShell-no_assertions. Defaults retain assertions; the action keeps separate caches for the two variants. All documented LLVM version examples use 23.1.2.The manifest records available assertion-free SDKs in optional
noassert_asset_nameandnoassert_download_urlfields. Existing default entries stay unchanged for older actions. All installers read the selected URL directly and reject unavailable variants before downloading assets. Checkout and source-archive installers use the adjacent manifest; standalone and piped scripts use main. The action uses its bundled manifest with a main fallback for unknown versions.Consolidate platform decoding in the generator and repeated test fixtures. The installer scripts are 52% shorter, and the two test files are 41% shorter. CI covers both current variants on all five supported platforms and samples historical SDKs, including LLVM 22.1.8. PowerShell requires 7.4 or newer for binary pipelines.
Validation: all 23 tests pass, including real ON/OFF installs and cache isolation. Line coverage increased from 75.49% to 86.48%; branch coverage increased from 64.84% to 72.09%. The bundled action and Bash install the published noassert SDK on Linux ARM; a C++/MLIR consumer builds and runs against it. Standalone Bash installation of 22.1.8 and PowerShell checkout/standalone/piped selection probes pass. Type checking, repository lint, workflow schemas, and generated-manifest consistency checks pass. The current follow-up updates examples only; formatting and repository checks pass. Hosted checks are rerunning for the new revision.
AI assistance covered implementation, independent specialist review, and validation.