ENV (superenv / stdenv): Mark every future version of GCC above gcc-4.8 (including the as-of-current-writing gcc-7) as supporting C++11, which fixes ENV.cxx11 usage in Tigerbrew formulae.
#767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding the as-of-current-writing gcc-7) as supporting C++11, which fixes `ENV.cxx11` usage in Tigerbrew formulae. The previous version of the regular expression only detected `gcc-4.8`, `gcc-4.9`, and `gcc-5` as supporting C++11, but erroneously fails to detect newer versions of GCC as supporting C++11. This currently results in any Tigerbrew formulae using `ENV.cxx11` to incorrectly throw an error when a user has the latest version of the `gcc` formula installed (which installs `gcc-7` as of this writing). The updated regular expression successfully detects not only `gcc-7`, but also future versions all the way up to `gcc-99`(!) for futureproofing purposes, in case the `gcc` formula gets updated to a newer version of GCC at some point in the future.
akemin-dayo
force-pushed
the
c++11-gcc-support-detection-regex-fix
branch
from
a1b7364 to
8cc569b
Compare
akemin-dayo
changed the title
ENV.cxx11 usage in Tigerbrew formulae.ENV.cxx11 usage in Tigerbrew formulae.
akemin-dayo
added a commit
to akemin-dayo/tigerbrew
that referenced
this pull request
Oct 15, 2021
…1` flag will be correctly passed on to GCC. This depends on changes to ENV (superenv / stdenv) made in PR mistydemeo#767. Interestingly, aria2 actually builds fine even without `ENV.cxx11` being present… but including it is a much better / "proper" way to do this.
akemin-dayo
added a commit
to akemin-dayo/tigerbrew
that referenced
this pull request
Oct 16, 2021
…1` flag will be correctly passed on to GCC. This depends on changes to ENV (superenv / stdenv) made in PR mistydemeo#767. Interestingly, aria2 actually builds fine even without `ENV.cxx11` being present… but including it is a much better / "proper" way to do this.
|
Just tried to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the regular expression only detected
gcc-4.8,gcc-4.9, andgcc-5as supporting C++11, but erroneously fails to detect newer versions of GCC as supporting C++11.This currently results in any Tigerbrew formulae using
ENV.cxx11to incorrectly throw an error when a user has the latest version of thegccformula installed (which installsgcc-7as of this writing).The updated regular expression successfully detects not only
gcc-7, but also future versions all the way up togcc-99(!) for futureproofing purposes, in case thegccformula gets updated to a newer version of GCC at some point in the future.Here are some strings I tested against my modified regular expression to make sure it works correctly:
gcc-4.0→ No matchgcc-4.2→ No matchgcc-4.8→ Matchgcc-4.9→ Matchgcc-5→ Matchgcc-5.1→ Matchgcc-7→ Matchgcc-11→ Matchgcc-42→ Matchgcc-99→ Match