Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2: Updated to 1.36.0. Added OS X 10.4.x build support. Fixed building on 10.5.x as well as issue #394. Switched SSL library from GnuTLS to OpenSSL due to some process hanging issues with the former. Added expat for XML support. #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akemin-dayo
Copy link
Contributor

@akemin-dayo akemin-dayo commented Oct 15, 2021

In addition to fixing issue #394, this commit also includes some minor formula-level changes:

  • Updated the homepage URL to aria2's new GitHub Pages URL (which is where the previous one now redirects to).
  • Use assert_predicate instead of assert in the test block.

Planned future improvements / PRs:

  • Determine why some Tigerbrewed dependencies are not detected by aria2's configure script. Once this is fixed, Tigerbrew aria2 will be brought in line with modern aria2.
    • SFTP support: libssh2
    • XML support: XML support is currently provided by the expat dependency, but according to official aria2 documentation, libxml2 >= 2.6.24 is preferred by aria2 over expat for an unexplained reason.
      • On modern systems, system libxml2 is used. It is unclear to me exactly when Apple started shipping an appropriate version of the library to be detected and used by aria2's configure.
    • Browser cookie support: sqlite
  • Consider improving the needs :cxx11 recommendation message, the current iteration of which can be found here:
    # raised by CompilerSelector if the formula fails with all of
    # the compilers available on the user's system
    class CompilerSelectionError < RuntimeError
    def initialize(formula)
    super <<-EOS.undent
    #{formula.full_name} cannot be built with any available compilers.
    To install this formula, you may need to either:
    brew install apple-gcc42
    or:
    brew install gcc
    EOS
    end
    end

brew install aria2PASS (OS X 10.5.8 and 10.4.11, both PowerPC)
brew audit aria2PASS

@akemin-dayo akemin-dayo force-pushed the aria2-update-and-build-fixes branch from a198835 to 78d2ccc Compare October 15, 2021 11:58
@akemin-dayo akemin-dayo marked this pull request as draft October 15, 2021 11:58
@akemin-dayo akemin-dayo changed the title aria2: Updated to 1.36.0. Added OS X 10.4.x build support. Fixed building on 10.5.x as well as issue #394. aria2: Updated to 1.36.0. Added OS X 10.4.x build support. Fixed building on 10.5.x as well as issue #394. Switched SSL library from GnuTLS to OpenSSL due to some hanging issues with the former. Oct 15, 2021
@akemin-dayo akemin-dayo marked this pull request as ready for review October 15, 2021 13:41
@akemin-dayo akemin-dayo marked this pull request as draft October 15, 2021 16:27
…ding on 10.5.x as well as issue mistydemeo#394. Switched SSL library from GnuTLS to OpenSSL due to some process hanging issues with the former. Added `expat` for XML support.

This commit also includes some minor formula-level changes:
* Updated the homepage URL to aria2's new GitHub Pages URL (which is where the previous one now redirects to).
* Use `assert_predicate` instead of `assert` in the `test` block.
@akemin-dayo akemin-dayo force-pushed the aria2-update-and-build-fixes branch from 78d2ccc to 4f54631 Compare October 16, 2021 02:17
@akemin-dayo akemin-dayo changed the title aria2: Updated to 1.36.0. Added OS X 10.4.x build support. Fixed building on 10.5.x as well as issue #394. Switched SSL library from GnuTLS to OpenSSL due to some hanging issues with the former. aria2: Updated to 1.36.0. Added OS X 10.4.x build support. Fixed building on 10.5.x as well as issue #394. Switched SSL library from GnuTLS to OpenSSL due to some process hanging issues with the former. Added expat for XML support. Oct 16, 2021
@akemin-dayo akemin-dayo marked this pull request as ready for review October 16, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant