aria2: Add missing ENV.cxx11 in the install block so the -std=c++11 flag will be correctly passed on to GCC. [Depends on PR #767 — do not merge until then]
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akemin-dayo
changed the title
ENV.cxx11 in the install block so the -std=c++11 flag will be correctly passed on to GCC.ENV.cxx11 in the install block so the -std=c++11 flag will be correctly passed on to GCC.
akemin-dayo
changed the title
ENV.cxx11 in the install block so the -std=c++11 flag will be correctly passed on to GCC.ENV.cxx11 in the install block so the -std=c++11 flag will be correctly passed on to GCC. [Depends on PR #767 — do not merge until then]
…1` flag will be correctly passed on to GCC. This depends on changes to ENV (superenv / stdenv) made in PR mistydemeo#767. Interestingly, aria2 actually builds fine even without `ENV.cxx11` being present… but including it is a much better / "proper" way to do this.
akemin-dayo
force-pushed
the
aria2-add-missing-env-cxx11
branch
from
492206f to
4a4a1ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: DO NOT MERGE UNTIL PR #767 IS MERGED.
This PR depends on changes to ENV (superenv / stdenv) made in PR #767.
Interestingly, aria2 actually builds fine even without
ENV.cxx11being present… but including it is a much better / "proper" way to do this.※ Notes regarding OS X 10.4.x: Specifying
-std=c++11(which is whatENV.cxx11does) on 10.4.x, at least withgcc-7causes the build to fail as if the compiler does not support C++11 (which it most definitely does).For some reason, omitting this flag actually allows aria2 to successfully build and run on OS X 10.4.x.
As a result,
ENV.cxx11is currently not set when building on OS X 10.4.x.I'll have to verify sometime later in the future if this behaviour occurs with other versions of GCC that support C++11 (such as
gcc-6orgcc-5), or if it is somehow specific togcc-7.brew install aria2→ PASS (OS X 10.5.8 and OS X 10.4.11, both PowerPC)brew audit aria2→ PASS