-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimatch for directory exclusion #1091
Minimatch for directory exclusion #1091
Conversation
@microsoft-github-policy-service agree company="Appgate" |
fb47a50
to
18c374a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
=======================================
+ Coverage 75.7% 76.1% +0.4%
=======================================
Files 245 246 +1
Lines 10972 11378 +406
Branches 1101 1174 +73
=======================================
+ Hits 8307 8663 +356
- Misses 2343 2372 +29
- Partials 322 343 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution to the repo! There are some things that I've noted which would be needed before we're able to accept the contribution 👍
Since this would be a breaking change in how our directory exclusion pattern works for downstream consumers, I've tagged it for the next major release of Component Detection.
Do you have a timeline when this is needed for your tooling? Generally speaking we try and give a few weeks heads before pushing major versions.
Sorry. I've been quite busy the last weeks. I hope I could get back to it this week. |
Missed your question before. I've worked around this in our tooling. So for us this isn't necessary. Just thought it would be a nice upgrade to the repo. |
* License attribution * RegexOptions.Compiled * Better exception message * Better test coverage
18c374a
to
5805006
Compare
@cobya - Updated with respect to your comments last week. Please have a look to see if it looks good to you. |
Thanks again for the contribution here 🫶 I've merged the changes into the |
To me the description on how to define DirectoryExclusionList was very confusing since the comparison was globing and not minimatch and that there was no mention of ';' being used to define multiple patterns. This PR aims to solve both of those issues.
The minimatch implementation is a port of https://github.com/isaacs/minimatch to C#.