Investigate our use of ** with Dotnet.Glob

[JamieMagee]

I believe we are incorrectly using the ** pattern. We rolled back in #200, but would like to upgrade still.

Sources:

• https://github.com/microsoft/component-detection/releases/tag/v1.2.1
• chore(deps): update dependency dotnet.glob to v2.1.4 #138
• Incorrect match with ** dazinator/DotNet.Glob#65
• dazinator/DotNet.Glob@f1ee0ef

[JamieMagee]

The issue is here:

component-detection/src/Microsoft.ComponentDetection.Orchestrator/Services/DetectorProcessingService.cs

Lines 188 to 191 in 0f3fa8a

	foreach (var directoryExclusion in directoryExclusionList)
	{
	minimatchers.Add(directoryExclusion, Glob.Parse(allowWindowsPaths ? directoryExclusion : /* [] escapes special chars */ directoryExclusion.Replace("\\", "[\\]"), globOptions));
	}

If we pass **/samples/** it throws IndexOutOfRangeException

Glob.Parse("**/samples/**").IsMatch("d:\\df\\samples") is a minimal example.

[cobya]

Ideally most of these issues will be resolved after the changes from #1091 are merged.