Skip to content

Minimatch for directory exclusion #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2024
Merged

Minimatch for directory exclusion #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ad6ce4
Minimatch for directory exclusion
chriskarlsson Apr 29, 2024
5805006
PR comment fixes
chriskarlsson May 14, 2024
8c7595d
Merge branch 'main' into chriskarlsson/minimatch-on-directory-exclusion
chriskarlsson May 16, 2024
e0161c9
Merge branch 'main' into chriskarlsson/minimatch-on-directory-exclusion
chriskarlsson May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/detector-arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dotnet run --project "src\Microsoft.ComponentDetection\Microsoft.ComponentDetect
```

--DirectoryExclusionList Filters out specific directories following a
minimatch pattern.
semicolon separated list of minimatch patterns.

--IgnoreDirectories Filters out specific directories, providing
individual directory paths separated by semicolon.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ComponentDetection.Orchestrator/Commands/ScanSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Commands;
public class ScanSettings : BaseSettings
{
[CommandOption("--DirectoryExclusionList")]
[Description("Filters out specific directories following a minimatch pattern.")]
[Description("Filters out specific directories following a semicolon separated list of minimatch patterns.")]
[TypeConverter(typeof(SemicolonDelimitedConverter))]
public IEnumerable<string> DirectoryExclusionList { get; set; }

Expand Down
1 change: 0 additions & 1 deletion ...icrosoft.ComponentDetection.Orchestrator/Microsoft.ComponentDetection.Orchestrator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<ItemGroup>
<PackageReference Include="CommandLineParser" />
<PackageReference Include="DotNet.Glob" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Logging" />
<PackageReference Include="Newtonsoft.Json" />
Expand Down
Loading
Loading