docker: fix ffmpeg build #3825
Merged
docker: fix ffmpeg build #3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the docker build broke, maybe due to a runner or package update. Updating ffmpeg itself to 8.0.1 might fix it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3825 +/- ##
============================================
Coverage ? 31.67700%
============================================
Files ? 159
Lines ? 39022
Branches ? 0
============================================
Hits ? 12361
Misses ? 25771
Partials ? 890 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes the ffmpeg build in Docker that somehow broke.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the docker build broke, maybe due to a package update since the ffmpeg build script has not been updated in a while.
Fix this by building NASM, ported over from the LPMS install script. For some reason the LPMS nasm also breaks in a different way (it's probably too old) so use the latest NASM release, 3.01