[WIP] docker: Fix docker image build #3832
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
The
nasmversion was recently upgraded in the indexes, which brokeour ffmpeg build. Apparently ffmpeg has trouble with versions 2.16+ of
nasm.The exact version was determined by running a couple commands on my latest
go-livepeerimage build to determine what version ofnasmwe used to havebefore:
We could also fix this by switching to
yasminstead ofnasm, but I don't even know whatthat package does so let's just do the safest thing and stick to the version that worked lol
Specific updates (required)
nasmversion on installHow did you test each of these updates (required)
Build
Does this pull request close any open issues?
https://discord.com/channels/423160867534929930/1447457162736570461
Checklist:
makeruns successfully./test.shpass