Skip to content

Conversation

@mjh1
Copy link
Member

@mjh1 mjh1 commented Dec 8, 2025

To help us try to understand the price mismatch issues we've been seeing.

@mjh1 mjh1 requested review from j0sh and victorges December 8, 2025 15:47
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.65300%. Comparing base (9f123db) to head (43c9835).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
eth/watchers/pricefeedwatcher.go 50.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3826         +/-   ##
===================================================
- Coverage   31.67769%   31.65300%   -0.02469%     
===================================================
  Files            159         159                 
  Lines          39018       39020          +2     
===================================================
- Hits           12360       12351          -9     
- Misses         25763       25776         +13     
+ Partials         895         893          -2     
Files with missing lines Coverage Δ
eth/watchers/pricefeedwatcher.go 66.98113% <50.00000%> (-0.32656%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f123db...43c9835. Read the comment docs.

Files with missing lines Coverage Δ
eth/watchers/pricefeedwatcher.go 66.98113% <50.00000%> (-0.32656%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh
Copy link
Collaborator

j0sh commented Dec 8, 2025

LGTM, but I think things can't be deployed until SRE figures out what broke the ffmpeg build in Docker: #3825

@mjh1 mjh1 merged commit ba9c555 into master Dec 9, 2025
17 of 18 checks passed
@mjh1 mjh1 deleted the mh/ticker branch December 9, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants