Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pypiserver to v2.2.0 #596

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Nov 26, 2024

Fixes #595, workaround for pypiserver/pypiserver#630.

Closes #594

Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski, LGTM

@brichet
Copy link
Contributor

brichet commented Nov 26, 2024

The tests that are failing are similar or I'm missing something ?
And none of them seem to be doing what they're supposed to, according to the names...

  test_minimum_versions:
    name: Test Minimum Versions
    timeout-minutes: 20
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
        with:
          dependency_type: pre
      - name: Run the unit tests
        run: |
          hatch run test:nowarn || hatch run test:nowarn --lf


  test_prereleases:
    name: Test Prereleases
    runs-on: ubuntu-latest
    timeout-minutes: 20
    steps:
      - uses: actions/checkout@v4
      - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
        with:
          dependency_type: pre
      - name: Run the tests
        run: |
          hatch run test:nowarn || hatch run test:nowarn --lf

@krassowski
Copy link
Collaborator Author

Good catch! I opened #597 to fix test_minimum_versions. Not sure what is wrong with test_prereleases though?

@krassowski
Copy link
Collaborator Author

I think that the pre-releases test timing out might be a real issue because pypiserver 2.2.0 did not support Python 3.13 (which was the point of 2.3.0) and this is what pre-releases are testing. Of course not great that these are timing out instead of failing.

@brichet
Copy link
Contributor

brichet commented Nov 26, 2024

Not sure what is wrong with test_prereleases though?

I through it was a test about releasing a version, you're right.

Of course not great that these are timing out instead of failing.

We should probably skip it until it is fixed upstream.

@krassowski
Copy link
Collaborator Author

We should probably skip it until it is fixed upstream.

Right, I commented it out of check job which is set as required. test_prereleases will keep failing but it will not block merging PRs in the meantime.

@krassowski krassowski enabled auto-merge (squash) November 26, 2024 15:39
@krassowski krassowski merged commit 44e8584 into jupyter-server:main Nov 26, 2024
19 of 20 checks passed
@krassowski krassowski deleted the pin-pypiserver branch November 26, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish-assets error
2 participants