Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish-assets error #595

Closed
brichet opened this issue Nov 25, 2024 · 7 comments · Fixed by #596
Closed

publish-assets error #595

brichet opened this issue Nov 25, 2024 · 7 comments · Fixed by #596
Labels
bug Something isn't working

Comments

@brichet
Copy link
Contributor

brichet commented Nov 25, 2024 •
edited
Loading

Description

the publish-assets action seems to fail on some repo:

Maybe more jupyter repo...

Reproduce

open a PR in one of the above repository

Expected behavior

The test to pass

Context

This is probably due to the last release of pypiserver https://github.com/pypiserver/pypiserver/releases/tag/v2.3.0

Note

I tried to reproduce it in the jupyter_releaser repository in #594, which run the same action and used the same version of pypiserver 2.3.2, without success.
@brichet brichet added the bug Something isn't working label Nov 25, 2024
This was referenced Nov 26, 2024
Merged
Closed
@krassowski
Copy link
Collaborator

Here is the output with --verbose from jupyterlab/jupyterlab#16997:

Uploading jupyterlab-4.4.0a1-py3-none-any.whl
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/11.9 MB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.9/11.9 MB • 00:00 • 178.0 MB/s
INFO     Response from http://0.0.0.0:8081/:
         400 Bad Request
INFO    
             <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
             <html>
                 <head>
                     <title>Error: 400 Bad Request</title>
                     <style type="text/css">
                       html {background-color: #eee; font-family: sans-serif;}
                       body {background-color: #fff; border: 1px solid #ddd;
                             padding: 15px; margin: 15px;}
                       pre {background-color: #eee; border: 1px solid #ddd;
         padding: 5px;}
                     </style>
                 </head>
                 <body>
                     <h1>Error: 400 Bad Request</h1>
                     <p>Sorry, the requested URL
         <tt>&#039;http://0.0.0.0:8081/&#039;</tt>
                        caused an error:</p>
                     <pre>MultipartError: Memory limit reached.</pre>
                 </body>
             </html>
ERROR    HTTPError: 400 Bad Request from http://0.0.0.0:8081/
         Bad Request

As to why it did not show up on #594 I think it is because this repo produces much smaller wheel:

Uploading jupyter_releaser-1.8.5-py3-none-any.whl
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/54.5 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 54.5/54.5 kB • 00:00 • 148.8 MB/s

@brichet
Copy link
Contributor Author

brichet commented Nov 26, 2024

Thanks @krassowski for diving into this, and thanks for the tip, I didn't know how to try my version of the workflow.

Curious about the result of your change, I wonder if the issue is not the use of bottle in a dev version, starting from pypiserver 2.3.0.

@brichet
Copy link
Contributor Author

brichet commented Nov 26, 2024

As to why it did not show up on #594 I think it is because this repo produces much smaller wheel:

Maybe yes, but jupyterlab-chat is not that big for example... even if it seems too big for the expected contents.

@krassowski
Copy link
Collaborator

Right, that is just 149.5 kB. Still mroe than 54.5 kB.

Uploading jupyterlab_chat-0.6.1-py3-none-any.whl
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/149.5 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 149.5/149.5 kB • 00:00 • 193.2 MB/s

Right now testing pinning versions, will have full data in 10 minutes

@krassowski
Copy link
Collaborator

Pinning confirms that all 2.3.x versions fail:

@krassowski
Copy link
Collaborator

For some reason jupyter-ai CI is green despite installing pypiserver-2.3.2, see https://github.com/jupyterlab/jupyter-ai/actions/runs/12011699089/job/33497731455. I think that the only meaningful difference is that it pinsPython version to python_version: "3.11.x" whereas the failing builds all use Python 3.12.

This was referenced Nov 26, 2024
Open
Merged
@krassowski
Copy link
Collaborator

I opened upstream issue and a PR to pin the version to 2.2.0 in the meantime:

@krassowski krassowski mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin pypiserver to v2.2.0 krassowski/jupyter_releaser
2 participants
@krassowski @brichet