Display cell in suggestion panel #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungleduc
force-pushed
the
copy-cell
branch
from
184108f to
b86864e
Compare
|
@jtpio I don't have a strong feeling about the last point. |
trungleduc
force-pushed
the
copy-cell
branch
from
0180030 to
c05e02d
Compare
trungleduc
force-pushed
the
copy-cell
branch
from
cbdd5fb to
437df00
Compare
|
Ignoring the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
ISuggestionsManagerToken: This token provides anISuggestionsManagerinstance that allows interaction with suggestions from all notebooks.ISuggestionsManagerTokentoken is aLocalSuggestionsManagerinstance, which works using notebook metadata, in the next step, another package can provide aRTCSuggestionsManagerto replace the default one.SuggestionsModelusesISuggestionsManagerTokento interact with the suggestions of the current notebook (add, remove...)SuggestionsModelis also exposed as a token (ISuggestionsModelToken) which is used inSuggestionsPanelWidgetand commands to handle user actions.