Draft for Jarring Animation #6 fix#10
Conversation
|
On the whole I think I like this approach! It's currently a little hard to review though since there are so many things going on at once. Here's what I think we should do, in order, and in separate PRs:
Also, thanks for setting up the UI preview server — that was very helpful! |
|
Sounds like a good plan (I would have worked a little more on the code the last few weeks, but I was travelling for the holidays) I'm a little busy at the moment, but I'll try to get to it as soon as I have a little time (though if anyone sees this, is free and wants to take point, please go ahead). And you're welcome for the preview servers :). The config is very simple just using Dockerfiles, docker-compose and Caddy, but if anyone wants to use them to host UI preview(s), I'll happily share them. |
|
No rush at all! I've been slow enough to get back to you that the least I can do is let you take your time 😅 |
|
@ghassanachi Looks like with all the other bits merged, this now has a few conflicts. Also, given you know more about the JS side of things than I do, any chance you could take care of the upgrade in #59 and #61? |
Proposed fix for #6.
I'm leaving this as a draft for now, since there are a couple choices I made that might need to be validated before a review is in order. And parts of the code need to be fixed (some of it is just indentation issues, discussed below).
To make testing the UI/UX changes a little easier, I've set up the current version and new version on a dev box (hope you don't mind me hosting them, I'll tear them down once the PR is merged). The poll rate has been dropped
1000mson the host view to make animation overlap more frequent.debounced: https://new.ghassanachi.com/
current: https://old.ghassanachi.com/
The backend is running in
debug/localmode, so you can use thesecretendpoint.debounced_secret: https://new.ghassanachi.com/event/00000000-0000-0000-0000-000000000000/secret
current_secret: https://old.ghassanachi.com/event/00000000-0000-0000-0000-000000000000/secret
Questions
clientcode. With different editor setups, i've had to turn off lsp formatting and manually indent things, which doesn't always work with whitespace because of different tab-size settings). Adding a formatter for the client should resolve the issue and guarantee consistency across machines.derivedstore, which seems to work well, but I wanted to check that we are okay with this change?transitionsin addition to theanimatedirective. Let me know what you think or if we should remove them? (Currently they are just there for UI/UX, but we could use the "on:outroend" event to drive the redraw code, instead of the fixesanimationTimevalue I set up.