Test and develop against Dynamodb Local#179
Merged
Merged
Conversation
jonhoo
reviewed
Nov 25, 2024
jonhoo
reviewed
Nov 25, 2024
Owner
|
This is great, thank you! |
Contributor
Author
It's my pleasure actually. I am wondering if the issues section is up-to-date, or some feature requests/issues are missing. |
jonhoo
reviewed
Dec 15, 2024
Owner
jonhoo
left a comment
jonhoo
left a comment
There was a problem hiding this comment.
The issues list should be up to date! At least I don't recall any other features I've wanted to be added since.
One thought: now that we have local dynamo, maybe we could make CI run the tests as well? Ideally one day we also have tests of the frontend, but at least running cargo test would be a start 🎉
Owner
|
Oh, I suppose there is also bringing #10 over the line |
jonhoo
approved these changes
Dec 19, 2024
Owner
|
Thank you! |
jonhoo
reviewed
Dec 19, 2024
Comment on lines
+49
to
+52
| AWS_DEFAULT_REGION=us-east-1 \ | ||
| AWS_ACCESS_KEY_ID=lorem \ | ||
| AWS_SECRET_ACCESS_KEY=ipsum \ | ||
| AWS_ENDPOINT_URL=http://localhost:8000 \ |
Owner
There was a problem hiding this comment.
Should we set it up so that there's just one environment variable to set (like USE_DYNAMODB=test), and when it's set like that then we set the others accordingly?
Contributor
Author
jonhoo
added a commit
that referenced
this pull request
Dec 27, 2024
PR #179 broke release builds by making it necessary for `LiveAskQuestion` and `SEED` to both now be available regardless of whether `debug_assertions` is set. That's unfortunate, since `SEED` in particular would make the binary quite large. So I've instead made it so that in release mode (or rather, without `debug_assertions`), `SEED` is _not_ compiled in, and DynamoDB mode is _always_ used. I've also added a CI job to check `--release --target aarch64-unknown-linux-gnu` so that this can't happen in the future.
Merged
jonhoo
added a commit
that referenced
this pull request
Dec 27, 2024
PR #179 broke release builds by making it necessary for `LiveAskQuestion` and `SEED` to both now be available regardless of whether `debug_assertions` is set. That's unfortunate, since `SEED` in particular would make the binary quite large. So I've instead made it so that in release mode (or rather, without `debug_assertions`), `SEED` is _not_ compiled in, and DynamoDB mode is _always_ used. I've also added a CI job to check `--release --target aarch64-unknown-linux-gnu` so that this can't happen in the future.
This was referenced Dec 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow for running e2e tests and developing against a local copy of DynamoDB with the ability to view changes in the admin panel: