feat: event to store#36
Merged
Merged
Conversation
jonhoo
approved these changes
Aug 13, 2023
Owner
jonhoo
left a comment
jonhoo
left a comment
There was a problem hiding this comment.
This seems entirely reasonable to me, thanks for picking it back up (and hope your move went well)!
Did you have a chance to also test this out yourself? I assume that means it worked without any meaningful changes to the behavior of the page?
Contributor
Author
|
The move went great! And yes, I've tested the changes. The behaviour of the application stays the same, the only noticeable change is that this fixes the double |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jon!
Congrats on the move and new position! Looking forward to the next Q&A to hear about your new position.
I've had my hands full since the start of the year (new job and a move like you 😄 ) and the changes I wanted to introduce to this repository slipped my mind. Your Q&A acted as a reminder yesterday!
This PR is introduces step 2 (
2. Move event to a store) of the changes mentioned in the draft PR. This update also fixes #1.Now that things have settled down a little I should have a little more time to complete the rest of the steps!
Cheers and enjoy Norway.
Looking forward to the next Crust Of Rust