Skip to content

Conversation

@batmat
Copy link
Member

@batmat batmat commented Dec 1, 2018

As 1.51 is upcoming (esp. to include the bump to extra-enforcer-rules to support JDK 11), the main goal here is to get an intermediate release with 1.50.
This way in case something goes wrong, it will be hopefully easier and quicker to figure where this comes from.

No JIRA, small enough.
Diff is jenkinsci/pom@jenkins-1.49...jenkins-1.50 (contains only the SUREFIRE-1588 workaround)

Proposed changelog entries

  • Internal: update to 1.50 parent pom to get the SUREFIRE-1588 workaround.

Submitter checklist

- [ ] JIRA issue is well described

  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jglick given changes in 1.50 all come from him.

As 1.51 is upcoming, main goal here is to get an intermediate release
with 1.50 in case we have data in case things go wrong with one or another
and more quickly figure if this is likely to be coming from 1.50 or 1.51.
@batmat batmat requested a review from jglick December 1, 2018 22:17
@batmat
Copy link
Member Author

batmat commented Dec 1, 2018

@daniel-beck @oleg-nenashev when/if the PR build is successful, I think it would be good to merge this before Monday so it gets in the next release.

I'm aware it's very late, so I'm fine if you think this is too dangerous.

I explained in the description that my intent here would be to get an intermediate release before we bump to upcoming 1.51, which I think would be better in case we have issues to diagnose.

Thanks a lot

@batmat batmat mentioned this pull request Dec 1, 2018
3 tasks
@batmat batmat closed this Dec 2, 2018
@batmat batmat reopened this Dec 2, 2018
@batmat batmat closed this Dec 2, 2018
@batmat batmat reopened this Dec 2, 2018
@batmat batmat closed this Dec 3, 2018
@batmat batmat reopened this Dec 3, 2018
@batmat
Copy link
Member Author

batmat commented Dec 3, 2018

Tests failures look unrelated and also happened on random PRs
image

On master:
image

poorManPerformanceTestBed I've no idea why it could fail because of this update. I assume this is unrelated.

Did someone see these failing elsewhere recently maybe?

@jglick
Copy link
Member

jglick commented Dec 4, 2018

testDeleteRecursive_onWindows does in fact flake frequently. I would suggest @Ignoreing it. poorManPerformanceTestBed does not ring a bell, but just from the name I would also suggest @Ignoreing it.

@batmat
Copy link
Member Author

batmat commented Dec 4, 2018

BTW, last PR rebuild only fails on the testDeleteRecursive_onWindows, which I'm proposing to ignore in #3787

image

@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat
Copy link
Member Author

batmat commented Dec 5, 2018

Facepalm, now the unrelated failure comes from a new test added for security-904 iiuc.

Groundhog day

@batmat
Copy link
Member Author

batmat commented Dec 5, 2018

FTR
screenshot_20181206-000529__01

@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat batmat added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 7, 2018
@batmat
Copy link
Member Author

batmat commented Dec 7, 2018

Unrelated test failures are a mess. I triple-checked and last rebuild failed also on
image

Exact same failure as on master currently, so I'm going to go ahead and merge this later today I think if nobody objects.

Got approval from Jesse (wouldn't obviously merge with 0 approval), and the upstream change is pretty limited anyway. I'll handle fallout if I missed something obvious even if seeming unlikely.

@batmat batmat merged commit f167f54 into jenkinsci:master Dec 7, 2018
@batmat batmat deleted the bump-to-parent-pom-1.50 branch December 7, 2018 13:18
@jglick
Copy link
Member

jglick commented Dec 10, 2018

Exact same failure as on master currently

FTR: #3799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants