Skip to content

Conversation

@batmat
Copy link
Member

@batmat batmat commented Dec 4, 2018

It is getting in the way of other in flight PRs, so we should disable to possibly take the time more serenely to fix this flakiness.

See JENKINS-55016.

For instance:

Proposed changelog entries

  • N/A

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

It is getting in the way of other in flight PRs, so we should disable
to possibly take the time more serenely to fix this flakiness.
@batmat batmat requested a review from daniel-beck December 4, 2018 16:45
@batmat batmat requested a review from jglick December 4, 2018 17:03
@batmat
Copy link
Member Author

batmat commented Dec 4, 2018

I will likely merge this one either later today (at least 4 hours), or tomorrow morning if I do not get pushback in the meantime.

I'm shortening the timeline a bit compared to usual given this has been blocking a lot of PRs, and given the ongoing issue with core rebuilds and agents' consumption, theses PRs make things even worse (because author will understandably retrigger their PR build to get a green build...)

@jvz
Copy link
Member

jvz commented Dec 4, 2018

I have a todo item to refactor this test to be more reliable. I'll try to contribute a fixed version back within a week or two.

@batmat
Copy link
Member Author

batmat commented Dec 4, 2018

Falling on poorManPerformanceTestBed only now. Going to merge and will probably file a similar PR for this other one tomorrow likely.

@batmat batmat merged commit 3421116 into jenkinsci:master Dec 4, 2018
@batmat batmat deleted the JENKINS-55016-disable-flake-testDeleteRecursive_onWindows branch December 4, 2018 20:39
@batmat
Copy link
Member Author

batmat commented Dec 4, 2018

Filed #3788 for analyzing the poorManPerformanceTestBed issue already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants