Switch to calling Files.newBufferedReader #3210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were suggested by Extra Hints for NetBeans IDE: http://plugins.netbeans.org/plugin/73447/
oleg-nenashev
added
the
needs-more-reviews
oleg-nenashev
approved these changes
Jan 7, 2018
| StringBuilder str = new StringBuilder((int)logfile.length()); | ||
|
|
||
| try (BufferedReader r = new BufferedReader(new InputStreamReader(Files.newInputStream(logfile.toPath()), charset))) { | ||
| try (BufferedReader r = Files.newBufferedReader(logfile.toPath(), charset)) { |
Member
There was a problem hiding this comment.
would be nice to use Util.fileToPath to avoid Runtime exceptions. But it can be done in a separate PR
daniel-beck
approved these changes
Jan 8, 2018
| File queueFile = getQueueFile(); | ||
| if (queueFile.exists()) { | ||
| try (BufferedReader in = new BufferedReader(new InputStreamReader(Files.newInputStream(queueFile.toPath())))) { | ||
| try (BufferedReader in = Files.newBufferedReader(queueFile.toPath(), Charset.defaultCharset())) { |
Member
There was a problem hiding this comment.
I wonder why we're not using UTF-8 here.
Member
There was a problem hiding this comment.
dunno. I am fine with fixing it in a separate PR. So far I think that all admins running Jenkins with non-UTF-8 just like to live dangerously, so I just wish them good luck
Author
oleg-nenashev
added
ready-for-merge
Member
|
Thanks @dtrebbien ! |
ghost
mentioned this pull request
oleg-nenashev
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Use fileToPath() This is a follow-up to PR 3210 on GitHub. See: #3210 (comment) * Switch two File.toPath() calls to Util.fileToPath() * Delete an unused import
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were suggested by Extra Hints for NetBeans IDE:
http://plugins.netbeans.org/plugin/73447/
This is somewhat related to JENKINS-42934.
Proposed changelog entries
None required
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers