Assume queueFile is UTF-8-encoded #3224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to PR 3210 on GitHub. See: #3210 (comment)
ghost
mentioned this pull request
4 tasks
oleg-nenashev
added
the
needs-more-reviews
Member
|
Nice try @daniel-beck |
oleg-nenashev
added
the
needs-jira-issue
Member
|
It would be nice to have a JIRA ticket for that since it is a potentially breaking change |
ghost
mentioned this pull request
4 tasks
Author
|
I have opened: https://issues.jenkins-ci.org/browse/JENKINS-48923 Also, it appears not to be possible to rename the branch of a GitHub pull request (see https://stackoverflow.com/questions/20007578/renaming-a-branch-while-on-pull-request). Closing this PR in favor of PR #3231... |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #3210 on GitHub. See:
#3210 (comment)
Proposed changelog entries
None required
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@daniel-beck
@oleg-nenashev