Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 8, 2018

This is a follow-up to PR #3210 on GitHub. See:
#3210 (comment)

Proposed changelog entries

None required

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev

This is a follow-up to PR 3210 on GitHub. See:
#3210 (comment)
@ghost ghost mentioned this pull request Jan 8, 2018
4 tasks
@oleg-nenashev oleg-nenashev added needs-more-reviews Complex change, which would benefit from more eyes ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Jan 8, 2018
@oleg-nenashev oleg-nenashev merged commit e8c86a3 into jenkinsci:master Jan 9, 2018
@oleg-nenashev
Copy link
Member

@dtrebbien thanks!

@oleg-nenashev
Copy link
Member

@dtrebbien It seems that this change causes some flakiness in the PR builder. E.g. https://ci.jenkins.io/blue/organizations/jenkins/Core%2Fjenkins/detail/PR-3238/6/tests

screen shot 2018-02-24 at 11 45 40

@ghost
Copy link
Author

ghost commented Feb 24, 2018

Hello @oleg-nenashev

Examining the stacktrace and line 47 of TextFileTest.java, it appears that the issue is within TextFile.fastTail() (or maybe somehow the temporary copy of ascii.txt is not fully written before it is read or the temporary copy is overwritten in the meantime?). However, fastTail() is not modified by this PR.

@ghost ghost mentioned this pull request Feb 25, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants