Redesign and change position of reporter options#1562
Merged
Conversation
vedhav
marked this pull request as ready for review
July 15, 2025 06:43
Contributor
Unit Tests Summary 1 files 25 suites 2m 3s ⏱️ Results for commit ebe959d. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 169dd5c ♻️ This comment has been updated with latest results. |
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: ebe959d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
|
Not sure if it fits here, but the 
I'm applying the following patch on #1559 as this is picked by e2e tests, but it also fits in this PR diff --git a/R/reporter_previewer_module.R b/R/reporter_previewer_module.R
index 19b707b34..758c1736c 100644
--- a/R/reporter_previewer_module.R
+++ b/R/reporter_previewer_module.R
@@ -43,6 +43,7 @@ reporter_previewer_module <- function(label = "Report previewer", server_args =
# This is to prevent another module being labeled "Report previewer".
class(module) <- c(class(module), "teal_module_previewer")
module$label <- label
+ module$path <- label
attr(module, "teal_bookmarkable") <- TRUE
module
} |
gogonzo
reviewed
Jul 15, 2025
- use preview_report_button_ui/srv - deprecate reporter_previewer_module
Target: `redesign-ui-ux@main` branch ### Changes description - Add count number to the "Module" navigation label ### Screenshots #### More than 1 module <img width="429" height="182" alt="image" src="https://github.com/user-attachments/assets/b427e118-5bc1-4d3f-b811-90936b5bd7ba" /> <img width="666" height="408" alt="image" src="https://github.com/user-attachments/assets/364e8353-9bc9-45b8-99dc-fc876ec8e999" /> #### 1 module <img width="666" height="408" alt="image" src="https://github.com/user-attachments/assets/c124786d-e180-4294-a9d4-7c9a720d86aa" /> ### Example code ```r pkgload::load_all("../teal.reporter") # branch: redesign-ui-ux pkgload::load_all("../teal") # branch: module_count@redesign-ui-ux@main init( data = teal_data(iris = iris, bla = list(123)), modules = modules( example_module("yada"), modules( label = "label", example_module(), example_module(), modules( label = "label2", example_module() ) ), example_module() ) ) |> runApp() ```
4 tasks
vedhav
force-pushed
the
redesign-ui-ux@main
branch
from
July 23, 2025 09:20
d8485a6 to
8292330
Compare
Refurnishing the code in module_teal and module_teal_module - Renamed `ui/srv_teal_module` to `.ui/srv_teal_module` as wrapper `ui/srv_teal_module` module - Introduced a wrapper module `ui/srv_teal_module` which gathers all nav-link(s) and tab-pane(s) and initialize input$active_module_id. "Wrapper module" returns fully functional navigation bar with switchable tabs - Output from "wrapper module" (`ui_teal_module`) returns a navbar to `ui_teal` where stuff can be appended/inserted to. --------- Co-authored-by: vedhav <vedhaviyash4@gmail.com>
gogonzo
reviewed
Jul 24, 2025
gogonzo
reviewed
Jul 24, 2025
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com> Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
vedhav
force-pushed
the
redesign-ui-ux@main
branch
from
July 24, 2025 06:42
d837ff6 to
a383aa5
Compare
vedhav
enabled auto-merge (squash)
July 24, 2025 06:59
gogonzo
approved these changes
Jul 24, 2025
gogonzo
left a comment
gogonzo
left a comment
Contributor
There was a problem hiding this comment.
Ready to go after resolving comments. Thanks Vedha 🥳
llrs-roche
reviewed
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of insightsengineering/teal.reporter#360
Closes #1539
In this PR:
global_knitrrmd_yaml_args,rmd_outputetc. will be controlled by options.teal_navbarto create a navigation bar and.teal_navbar_menuto create a dropdown menu.