Redesign and change position of reporter options

DESCRIPTION

@@ -55,7 +55,7 @@ Imports:
     stats,
     teal.code (>= 0.6.1),
     teal.logger (>= 0.4.0),
-    teal.reporter (>= 0.4.0.9004),
+    teal.reporter (>= 0.4.0.9005),
     teal.widgets (>= 0.4.3.9001),
     tools,
     utils

NAMESPACE

@@ -1,19 +1,17 @@
 # Generated by roxygen2: do not edit by hand
 
+S3method(.srv_teal_module,default)
+S3method(.srv_teal_module,teal_module)
+S3method(.srv_teal_module,teal_modules)
+S3method(.ui_teal_module,default)
+S3method(.ui_teal_module,teal_module)
+S3method(.ui_teal_module,teal_modules)
 S3method(c,teal_slices)
 S3method(format,teal_module)
 S3method(format,teal_modules)
 S3method(join_keys,tdata)
 S3method(print,teal_module)
 S3method(print,teal_modules)
-S3method(srv_teal_module,default)
-S3method(srv_teal_module,teal_module)
-S3method(srv_teal_module,teal_modules)
-S3method(ui_teal_module,default)
-S3method(ui_teal_module,teal_module)
-S3method(ui_teal_module,teal_modules)
-S3method(ui_teal_modules_nav_dropdown,teal_module)
-S3method(ui_teal_modules_nav_dropdown,teal_modules)
 S3method(within,teal_data_module)
 export(TealReportCard)
 export(add_landing_modal)

NEWS.md

@@ -1,5 +1,20 @@
 # teal 0.16.0.9015
 
+### Breaking changes
+
+* The `reporter_previewer_module()` is deprecated and will be removed in the future release. The custom `server_args` values can be set using `options()`:
+    - `teal.reporter.nav_buttons` to control which buttons will be displayed in the "Report" drop-down.
+    - `teal.reporter.rmd_outputs` to customize the R Markdown outputs types for the report.
+    - `teal.reporter.rmd_yaml_args` to customize the widget inputs in the download report modal.
+    - `teal.reporter.knitr_global` to customize the global `knitr` options for the report.
+
+### Enhancement
+
+* General repositioning of key navigation components across the app:
+    - Modules: The module navigation is moved from a nested tab selection to a "Module" drop-down selection. The module selection can be done from the nested button of modules.
+    - Reporter: The Report previewer is no longer displayed as yet another teal module, it is placed inside a "Report" drop-down right next to the "Module" drop-down. The Report previewer is a modal that displays the added report cards. The "Report" drop-down also contains other global report options like download/load/reset the Report.
+    - Teal Data Module: The UI created by the `teal_data_module()` is now placed inside a modal that can only be closed when it returns `teal_data`.
+
 # teal 0.16.0
 
 ### New features

R/init.R

@@ -204,6 +204,8 @@ init <- function(data,
     list(
       ui = function(request) {
         bslib::page_fluid(
+          theme = get_teal_bs_theme(),
+          style = "--bs-gutter-x: 0;",
           title = tags$div(
             id = "teal-app-title",
             tags$head(
@@ -217,6 +219,7 @@ init <- function(data,
           ),
           tags$header(
             id = "teal-header",
+            style = "margin: 0.5em",
             tags$div(id = "teal-header-content")
           ),
           ui_teal(
@@ -225,6 +228,7 @@ init <- function(data,
           ),
           tags$footer(
             id = "teal-footer",
+            style = "margin: 0.5em",
             tags$div(id = "teal-footer-content"),
             ui_session_info("teal-footer-session_info")
           )

R/module_bookmark_manager.R

@@ -50,21 +50,11 @@ ui_bookmark_panel <- function(id, modules) {
   is_unbookmarkable <- need_bookmarking(modules)
   shinyOptions(bookmarkStore = bookmark_option)
 
-  # Render bookmark warnings count
   if (!all(is_unbookmarkable) && identical(bookmark_option, "server")) {
-    tags$button(
+    .expand_button(
       id = ns("do_bookmark"),
-      class = "btn action-button wunder_bar_button bookmark_manager_button",
-      title = "Add bookmark",
-      tags$span(
-        suppressMessages(icon("fas fa-bookmark")),
-        if (any(is_unbookmarkable)) {
-          tags$span(
-            sum(is_unbookmarkable),
-            class = "badge-warning badge-count text-white bg-danger"
-          )
-        }
-      )
+      label = "Bookmark",
+      icon = "bookmark-fill"
     )
   }
 }
@@ -136,7 +126,8 @@ srv_bookmark_panel <- function(id, modules) {
             id = ns("bookmark_modal"),
             title = "Bookmarked teal app url",
             modal_content,
-            easyClose = TRUE
+            easyClose = TRUE,
+            footer = NULL
           )
         )
       )

R/module_data_summary.R

@@ -12,7 +12,7 @@
 #' Module includes also "Show/Hide unsupported" button to toggle rows of the summary table
 #' containing datasets where number of observations are not calculated.
 #'
-#' @inheritParams module_teal_modules_nav
+#' @inheritParams module_teal_module
 #'
 #' @name module_data_summary
 #' @rdname module_data_summary

R/module_filter_data.R

@@ -11,7 +11,7 @@
 #'  - tab is selected (`is_active`)
 #'  - when filters are changed (`get_filter_expr` is different than previous)
 #'
-#' @inheritParams module_teal_modules_nav
+#' @inheritParams module_teal_module
 #' @param active_datanames (`reactive` returning `character`) this module's data names
 #' @name module_filter_data
 #' @keywords internal

R/module_filter_manager.R

@@ -54,11 +54,10 @@ NULL
 #' @rdname module_filter_manager
 ui_filter_manager_panel <- function(id) {
   ns <- NS(id)
-  tags$button(
+  .expand_button(
     id = ns("show_filter_manager"),
-    class = "btn action-button wunder_bar_button",
-    title = "View filter mapping",
-    suppressMessages(icon("fas fa-grip"))
+    label = "Filter Manager",
+    icon = "funnel-fill"
   )
 }