Redesign and change position of reporter options

[gogonzo]

Companion with insightsengineering/teal#1562

In this PR:

• encoding related to download in reporter_previewer_ui has been removed and keep only buttons
• introduced a preview_report_button_ui/srv as an equivalent of (download/reset)_report_button_ui/srv

todo:

• buttons to move or remove reporter card in the previewer doesn't work
• decide the fate of reporter_previewer_ui taking into account the future refactor of the teal.reporter
• styling of the buttons in reporter_previewe_ui
• fix tests

[github-actions]

Unit Tests Summary

  1 files   20 suites   30s ⏱️
192 tests 192 ✅ 0 💤 0 ❌
333 runs  333 ✅ 0 💤 0 ❌

Results for commit 5c09cd2.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
DownloadModule	👶		$+1.16$	$+3$	$0$	$0$	$0$
PreviewerReportModule	💚	$1.84$	$-1.29$	$-5$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
DownloadModule	👶		$+1.16$	download_report_button_srv_download_a_document
PreviewerReportModule	💀	$0.17$	$-0.17$	reporter_previewer_srv_card_down
PreviewerReportModule	💀	$0.17$	$-0.17$	reporter_previewer_srv_card_up
PreviewerReportModule	💀	$0.25$	$-0.25$	reporter_previewer_srv_remove_a_card
PreviewerReportModule	💀	$0.49$	$-0.49$	reporter_previewer_srv_render_and_downlaod_a_document
Reporter	💀	$0.02$	$-0.02$	swap_cards
ResetModule	👶		$+0.14$	reset_report_button_srv_reset_a_reporter
ResetModule	💀	$0.16$	$-0.16$	simple_reporter_srv_reset_a_reporter
utils	💀	$0.01$	$-0.01$	get_bs_version

Results for commit 8e68d36

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------
R/AddCardModule.R           120       2  98.33%   142, 179
R/ContentBlock.R             15       2  86.67%   43-49
R/DownloadModule.R          234      67  71.37%   83-89, 143, 174-179, 188-193, 196-201, 210-215, 218-223, 231-236, 239-244, 251-256, 259-264, 303-307
R/FileBlock.R                13       0  100.00%
R/HTMLBlock.R                 9       0  100.00%
R/LoadReporterModule.R      101      19  81.19%   101-106, 109-114, 120-125, 137
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               247     106  57.09%   53-111, 182, 185, 188, 242, 275-281, 286, 290, 298-349
R/RcodeBlock.R               18       0  100.00%
R/Renderer.R                121      37  69.42%   97-112, 215, 225, 234, 236-257
R/ReportCard.R               86       3  96.51%   250, 255, 280
R/Reporter.R                 98      13  86.73%   148-160, 262-267
R/ResetModule.R              50       0  100.00%
R/SimpleReporter.R           30       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                15       0  100.00%
R/utils.R                   109      49  55.05%   26-55, 83, 107-115, 152-161
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      25      24  4.00%    2-24, 29-31
TOTAL                      1413     326  76.93%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  --------
R/AddCardModule.R           -27       0  -0.31%
R/DownloadModule.R           -5       0  -0.60%
R/LoadReporterModule.R       -3       0  -0.54%
R/Previewer.R              -122      +9  -16.63%
R/Reporter.R                 -9      +7  -7.66%
R/ResetModule.R              -4       0  +100.00%
R/SimpleReporter.R           -2       0  +100.00%
R/utils.R                   -17     -37  +23.30%
R/zzz.R                     +12     +12  -3.69%
TOTAL                      -177      -9  -2.00%

Results for commit: 5c09cd2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[gogonzo]

IMO everything here looks good. I can't approve as I've created a PR

[vedhav]

LGTM!