Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 13, 2025

No description provided.

@zguesmi zguesmi changed the title Feat/restore compatibility with iexec sdk feat: Make setName function as nonpayable to restore compatibility with iExec sdk Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (f7c634b) to head (78f55ca).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   83.66%   84.85%   +1.18%     
==========================================
  Files          38       37       -1     
  Lines        1218     1241      +23     
  Branches      227      235       +8     
==========================================
+ Hits         1019     1053      +34     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi deployed to production October 14, 2025 10:13 — with GitHub Actions Active
@PierreJeanjacquot PierreJeanjacquot self-requested a review October 14, 2025 14:37
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iexec SDK tests successful with 6.1.0-rc.4

@zguesmi
Copy link
Member Author

zguesmi commented Oct 14, 2025

iexec SDK tests successful with 6.1.0-rc.4

Perfect, thank you!
This patch will be available in the upcoming version 6.1.0.

@zguesmi zguesmi marked this pull request as ready for review October 14, 2025 15:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the setName function mutability from view to nonpayable across registry contracts to restore compatibility with the iExec SDK while maintaining the function's behavior of reverting on non-Bellecour chains.

  • Updated function signature from view to nonpayable in Registry and RegistryEntry contracts
  • Added dummy state variable assignments to avoid Solidity compiler warnings
  • Updated all corresponding ABI files to reflect the mutability change

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Version bump from 6.1.0-rc3 to 6.1.0-rc4
docs/solidity/index.md Updated documentation to reflect nonpayable mutability and reorganized sections
contracts/registries/Registry.sol Changed setName mutability to nonpayable and added dummy assignment
contracts/registries/RegistryEntry.sol Changed setName mutability to nonpayable and added dummy assignment
Multiple ABI files Updated stateMutability from "view" to "nonpayable" for setName functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zguesmi zguesmi self-assigned this Oct 14, 2025
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi merged commit f2ae2c3 into main Oct 15, 2025
4 checks passed
@zguesmi zguesmi deleted the feat/restore-compatibility-with-iexec-sdk branch October 15, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants