-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Make setName
function as nonpayable to restore compatibility with iExec sdk
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setName
function as nonpayable to restore compatibility with iExec sdk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 83.66% 84.85% +1.18%
==========================================
Files 38 37 -1
Lines 1218 1241 +23
Branches 227 235 +8
==========================================
+ Hits 1019 1053 +34
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iexec SDK tests successful with 6.1.0-rc.4
Perfect, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the setName
function mutability from view
to nonpayable
across registry contracts to restore compatibility with the iExec SDK while maintaining the function's behavior of reverting on non-Bellecour chains.
- Updated function signature from
view
tononpayable
in Registry and RegistryEntry contracts - Added dummy state variable assignments to avoid Solidity compiler warnings
- Updated all corresponding ABI files to reflect the mutability change
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
package.json | Version bump from 6.1.0-rc3 to 6.1.0-rc4 |
docs/solidity/index.md | Updated documentation to reflect nonpayable mutability and reorganized sections |
contracts/registries/Registry.sol | Changed setName mutability to nonpayable and added dummy assignment |
contracts/registries/RegistryEntry.sol | Changed setName mutability to nonpayable and added dummy assignment |
Multiple ABI files | Updated stateMutability from "view" to "nonpayable" for setName functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.