Skip to content

feat: Make setName function as nonpayable to restore compatibility with iExec sdk #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2025
Merged

feat: Make setName function as nonpayable to restore compatibility with iExec sdk #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bce551a
feat: Make `setName` function nonpayable
zguesmi Oct 13, 2025
19f5a77
docs: Upate solidity docs
zguesmi Oct 13, 2025
07a00d5
chore: v6.1.0-rc4
zguesmi Oct 14, 2025
78f55ca
chore: Merge branch 'main' into feat/restore-compatibility-with-iexec…
zguesmi Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion abis/contracts/registries/Registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
},
{
Expand Down
2 changes: 1 addition & 1 deletion abis/contracts/registries/RegistryEntry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
}
]
2 changes: 1 addition & 1 deletion abis/contracts/registries/apps/App.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
}
]
2 changes: 1 addition & 1 deletion abis/contracts/registries/apps/AppRegistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
},
{
Expand Down
2 changes: 1 addition & 1 deletion abis/contracts/registries/datasets/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
}
]
2 changes: 1 addition & 1 deletion abis/contracts/registries/datasets/DatasetRegistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
},
{
Expand Down
2 changes: 1 addition & 1 deletion abis/contracts/registries/workerpools/Workerpool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
}
]
2 changes: 1 addition & 1 deletion abis/contracts/registries/workerpools/WorkerpoolRegistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@
],
"name": "setName",
"outputs": [],
"stateMutability": "view",
"stateMutability": "nonpayable",
"type": "function"
},
{
Expand Down
9 changes: 5 additions & 4 deletions contracts/registries/Registry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,13 @@ abstract contract Registry is IRegistry, ERC721, Ownable {

/**
* Sets the reverse registration name for a registry contract.
* @dev This functionality is supported only on the Bellecour chain.
* On other chains, this function will revert to maintain retrocompatibility
* in the SDK.
* @dev This functionality is supported only on Bellecour Sidechain, calls on other chains
* will revert. The function is kept as nonpayable to maintain retrocompatibility with the
* iExec SDK.
*/
// TODO remove this function when Bellecour is deprecated.
function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner {
function setName(address /* _ens */, string calldata /* _name */) external onlyOwner {
initialized = initialized; // Remove solidity state mutability warning.
revert("Operation not supported on this chain");
}

Expand Down
9 changes: 5 additions & 4 deletions contracts/registries/RegistryEntry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ abstract contract RegistryEntry {

/**
* Sets the reverse registration name for a registry entry contract.
* @dev This functionality is supported only on the Bellecour chain.
* On other chains, this function will revert to maintain retrocompatibility
* in the SDK.
* @dev This functionality is supported only on Bellecour Sidechain, calls on other chains
* will revert. The function is kept as nonpayable to maintain retrocompatibility with the
* iExec SDK.
*/
// TODO remove this function when Bellecour is deprecated.
function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner {
function setName(address /* _ens */, string calldata /* _name */) external onlyOwner {
registry = registry; // Remove solidity state mutability warning.
revert("Operation not supported on this chain");
}

Expand Down
Loading