feat: Make setName function as nonpayable to restore compatibility with iExec sdk (#286)

zguesmi · web-flow · commit f2ae2c39ff5c · 2025-10-15T15:38:10.000+02:00
diff --git a/abis/contracts/registries/Registry.json b/abis/contracts/registries/Registry.json
@@ -453,7 +453,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {
diff --git a/abis/contracts/registries/RegistryEntry.json b/abis/contracts/registries/RegistryEntry.json
@@ -40,7 +40,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   }
 ]
diff --git a/abis/contracts/registries/apps/App.json b/abis/contracts/registries/apps/App.json
@@ -138,7 +138,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   }
 ]
diff --git a/abis/contracts/registries/apps/AppRegistry.json b/abis/contracts/registries/apps/AppRegistry.json
@@ -525,7 +525,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {
diff --git a/abis/contracts/registries/datasets/Dataset.json b/abis/contracts/registries/datasets/Dataset.json
@@ -102,7 +102,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   }
 ]
diff --git a/abis/contracts/registries/datasets/DatasetRegistry.json b/abis/contracts/registries/datasets/DatasetRegistry.json
@@ -505,7 +505,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {
diff --git a/abis/contracts/registries/workerpools/Workerpool.json b/abis/contracts/registries/workerpools/Workerpool.json
@@ -141,7 +141,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   }
 ]
diff --git a/abis/contracts/registries/workerpools/WorkerpoolRegistry.json b/abis/contracts/registries/workerpools/WorkerpoolRegistry.json
@@ -485,7 +485,7 @@
     ],
     "name": "setName",
     "outputs": [],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {
diff --git a/contracts/registries/Registry.sol b/contracts/registries/Registry.sol
@@ -45,12 +45,13 @@ abstract contract Registry is IRegistry, ERC721, Ownable {
 
     /**
      * Sets the reverse registration name for a registry contract.
-     * @dev This functionality is supported only on the Bellecour chain.
-     * On other chains, this function will revert to maintain retrocompatibility
-     * in the SDK.
+     * @dev This functionality is supported only on Bellecour Sidechain, calls on other chains
+     * will revert. The function is kept as nonpayable to maintain retrocompatibility with the
+     * iExec SDK.
      */
     // TODO remove this function when Bellecour is deprecated.
-    function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner {
+    function setName(address /* _ens */, string calldata /* _name */) external onlyOwner {
+        initialized = initialized; // Remove solidity state mutability warning.
         revert("Operation not supported on this chain");
     }
 
diff --git a/contracts/registries/RegistryEntry.sol b/contracts/registries/RegistryEntry.sol
@@ -23,12 +23,13 @@ abstract contract RegistryEntry {
 
     /**
      * Sets the reverse registration name for a registry entry contract.
-     * @dev This functionality is supported only on the Bellecour chain.
-     * On other chains, this function will revert to maintain retrocompatibility
-     * in the SDK.
+     * @dev This functionality is supported only on Bellecour Sidechain, calls on other chains
+     * will revert. The function is kept as nonpayable to maintain retrocompatibility with the
+     * iExec SDK.
      */
     // TODO remove this function when Bellecour is deprecated.
-    function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner {
+    function setName(address /* _ens */, string calldata /* _name */) external onlyOwner {
+        registry = registry; // Remove solidity state mutability warning.
         revert("Operation not supported on this chain");
     }
 
diff --git a/docs/solidity/index.md b/docs/solidity/index.md
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,7 @@`
`453`	`453`	`],`
`454`	`454`	`"name": "setName",`
`455`	`455`	`"outputs": [],`
`456`		`- "stateMutability": "view",`
	`456`	`+ "stateMutability": "nonpayable",`
`457`	`457`	`"type": "function"`
`458`	`458`	`},`
`459`	`459`	`{`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@`
`40`	`40`	`],`
`41`	`41`	`"name": "setName",`
`42`	`42`	`"outputs": [],`
`43`		`- "stateMutability": "view",`
	`43`	`+ "stateMutability": "nonpayable",`
`44`	`44`	`"type": "function"`
`45`	`45`	`}`
`46`	`46`	`]`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@`
`138`	`138`	`],`
`139`	`139`	`"name": "setName",`
`140`	`140`	`"outputs": [],`
`141`		`- "stateMutability": "view",`
	`141`	`+ "stateMutability": "nonpayable",`
`142`	`142`	`"type": "function"`
`143`	`143`	`}`
`144`	`144`	`]`
Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,7 @@`
`525`	`525`	`],`
`526`	`526`	`"name": "setName",`
`527`	`527`	`"outputs": [],`
`528`		`- "stateMutability": "view",`
	`528`	`+ "stateMutability": "nonpayable",`
`529`	`529`	`"type": "function"`
`530`	`530`	`},`
`531`	`531`	`{`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@`
`102`	`102`	`],`
`103`	`103`	`"name": "setName",`
`104`	`104`	`"outputs": [],`
`105`		`- "stateMutability": "view",`
	`105`	`+ "stateMutability": "nonpayable",`
`106`	`106`	`"type": "function"`
`107`	`107`	`}`
`108`	`108`	`]`
Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@`
`505`	`505`	`],`
`506`	`506`	`"name": "setName",`
`507`	`507`	`"outputs": [],`
`508`		`- "stateMutability": "view",`
	`508`	`+ "stateMutability": "nonpayable",`
`509`	`509`	`"type": "function"`
`510`	`510`	`},`
`511`	`511`	`{`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@`
`141`	`141`	`],`
`142`	`142`	`"name": "setName",`
`143`	`143`	`"outputs": [],`
`144`		`- "stateMutability": "view",`
	`144`	`+ "stateMutability": "nonpayable",`
`145`	`145`	`"type": "function"`
`146`	`146`	`}`
`147`	`147`	`]`
Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@`
`485`	`485`	`],`
`486`	`486`	`"name": "setName",`
`487`	`487`	`"outputs": [],`
`488`		`- "stateMutability": "view",`
	`488`	`+ "stateMutability": "nonpayable",`
`489`	`489`	`"type": "function"`
`490`	`490`	`},`
`491`	`491`	`{`