Adding kernel for Newton-Schulz inverse#107
Merged
Merged
Conversation
gioelegott
approved these changes
Apr 16, 2026
Collaborator
gioelegott
left a comment
There was a problem hiding this comment.
Tested locally and everything passes. I trust @asobczyk for the correct absolute and relative errors.
I left some minor comments, but feel free to merge.
zouzias
reviewed
Apr 16, 2026
zouzias
reviewed
Apr 16, 2026
zouzias
reviewed
Apr 16, 2026
| * X = Y @ X + 2 * X | ||
| * return X | ||
| */ | ||
| template <typename InputT, typename OutputT, uint32_t MatrixSize> |
Collaborator
There was a problem hiding this comment.
Nitpick for doxygen docs. I thought CI should complain about it :-(
zouzias
approved these changes
Apr 16, 2026
Collaborator
zouzias
left a comment
There was a problem hiding this comment.
Minor nitpicks, feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.