feat(proguard): Support rewriteFrame annotation #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
romtsn
commented
Dec 12, 2025
loewenheim
reviewed
Dec 17, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Aside from the cache version bump and the API docs this looks great 👍
Member
Author
|
@loewenheim this should be good to review now, added docs and updated CacheVersion, also added an integration test |
loewenheim
approved these changes
Dec 19, 2025
romtsn
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 26, 2026
Depends on getsentry/symbolicator#1845 This is necessary for complete symbolication of Java frames when there are [rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0) annotations involved. See the linked PR.
dashed
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 26, 2026
Depends on getsentry/symbolicator#1845 This is necessary for complete symbolication of Java frames when there are [rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0) annotations involved. See the linked PR.
dashed
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 26, 2026
Depends on getsentry/symbolicator#1845 This is necessary for complete symbolication of Java frames when there are [rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0) annotations involved. See the linked PR.
JonasBa
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 27, 2026
Depends on getsentry/symbolicator#1845 This is necessary for complete symbolication of Java frames when there are [rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0) annotations involved. See the linked PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to reuse
remap_framefrom ProguardCache to delegate as much logic to it as possible and keep it lean on the caller side.Additionally, had to extend the
JvmStacktraceinterface, because we now need theJvmExceptionassociated with the stacktrace to correctly apply rewrite rules.Depends on getsentry/rust-proguard#67