Skip to content

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Dec 12, 2025

Depends on getsentry/symbolicator#1845

This is necessary for complete symbolication of Java frames when there are rewriteFrame annotations involved. See the linked PR.

@romtsn romtsn requested a review from loewenheim December 12, 2025 13:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #104851   +/-   ##
========================================
  Coverage   80.49%    80.49%           
========================================
  Files        9371      9371           
  Lines      402261    402269    +8     
  Branches    25841     25841           
========================================
+ Hits       323790    323798    +8     
  Misses      78023     78023           
  Partials      448       448           

@getsantry getsantry bot added the Stale label Jan 8, 2026
@getsantry
Copy link
Contributor

getsantry bot commented Jan 8, 2026

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@romtsn
Copy link
Member Author

romtsn commented Jan 8, 2026

please don't

@getsantry getsantry bot closed this Jan 16, 2026
@romtsn romtsn reopened this Jan 19, 2026
@getsantry getsantry bot removed the Stale label Jan 20, 2026
@romtsn romtsn force-pushed the rz/feat/java-symbolicate-stacktraces-with-exceptions branch from cc9eccd to 8548544 Compare January 23, 2026 17:06
@romtsn
Copy link
Member Author

romtsn commented Jan 23, 2026

Tested one more time locally -- works end-to-end (removes 2 inline frames):

Unsymbolicated

image

Symbolicated

Google Chrome 2026-01-23 19 13 53

with the following mapping:

    6:7:void androidx.core.view.MenuHostHelper.addMenuProvider(androidx.core.view.MenuProvider):133:134 -> addMenuProvider
    6:7:void androidx.core.view.MenuHostHelper.addMenuProvider(androidx.core.view.MenuProvider,androidx.lifecycle.LifecycleOwner):147 -> addMenuProvider
    6:7:void addMenuProvider(androidx.core.view.MenuProvider,androidx.lifecycle.LifecycleOwner):479 -> addMenuProvider
      # {"id":"com.android.tools.r8.rewriteFrame","conditions":["throws(Ljava/lang/NullPointerException;)"],"actions":["removeInnerFrames(2)"]}

@romtsn romtsn merged commit d78e949 into master Jan 26, 2026
66 checks passed
@romtsn romtsn deleted the rz/feat/java-symbolicate-stacktraces-with-exceptions branch January 26, 2026 08:42
dashed pushed a commit that referenced this pull request Jan 26, 2026
Depends on getsentry/symbolicator#1845

This is necessary for complete symbolication of Java frames when there
are
[rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0)
annotations involved. See the linked PR.
dashed pushed a commit that referenced this pull request Jan 26, 2026
Depends on getsentry/symbolicator#1845

This is necessary for complete symbolication of Java frames when there
are
[rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0)
annotations involved. See the linked PR.
JonasBa pushed a commit that referenced this pull request Jan 27, 2026
Depends on getsentry/symbolicator#1845

This is necessary for complete symbolication of Java frames when there
are
[rewriteFrame](https://r8.googlesource.com/r8/+/refs/heads/main/doc/retrace.md#rewriteframe-introduced-at-version-2_0)
annotations involved. See the linked PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants