-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat(r8): Support rewriteFrames annotation in ProguardCache
#67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
loewenheim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to consider how you're going to use this from Symbolicator, since you won't be able to just use remap_stacktrace. My suggestion would be to move some of the logic into remap_frame.
…ames-support-cache
src/cache/mod.rs
Outdated
| } | ||
|
|
||
| next_frame_can_rewrite = false; | ||
| current_exception_descriptor = None; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
489e411 to
9ab3a72
Compare
@loewenheim I have attempted to consolidate the logic under |
|
@romtsn The logic is good. However, I would suggest leaving |
thanks, this makes sense! I will move it over to a new method |
Attempts to reuse `remap_frame` from ProguardCache to delegate as much logic to it as possible and keep it lean on the caller side. Additionally, had to extend the `JvmStacktrace` interface, because we now need the `JvmException` associated with the stacktrace to correctly apply rewrite rules. Depends on getsentry/rust-proguard#67
Closes #63
See linked issue for more details.