Update IC links #408
Merged
Update IC links #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
Contributor
|
@ChunYen-Chen Please solve the conflicts. |
Conflicts: example/test_problem/ELBDM/DiskHeating/download_ic.sh
Conflicts: example/test_problem/Hydro/AGORA_IsolatedGalaxy/download_ic.sh
vivi235711
reviewed
Jan 21, 2025
Collaborator
Author
|
I added |
vivi235711
reviewed
Jan 22, 2025
Contributor
vivi235711
left a comment
vivi235711
left a comment
There was a problem hiding this comment.
I have downloaded all the ICs and confirmed that they are the same as the old ICs. All the sha256sum work.
In yt Hub, there are 4 ICs that are not included in this pr: FermiBubble, LSS_Zoomin, Riemann and UniformGranule.
Collaborator
Author
|
@vivi235711 Thanks for the review. Those test problems are not merged in the GAMER yet, so the related download codes are not included in this PR.
|
vivi235711
approved these changes
Jan 23, 2025
hyschive
reviewed
Jan 24, 2025
Contributor
hyschive
left a comment
hyschive
left a comment
There was a problem hiding this comment.
@ChunYen-Chen @vivi235711 Thanks for the PR and review! I have only one minor comment.
example/test_problem/ELBDM/LSS_Hybrid/download_spectral_interpolation_tables.sh
Show resolved
Hide resolved
hyschive
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #390.
All the ICs are now on the GAMER ythub.
Add
sha256sumdownload completeness checkNote
CDM_LSSis not included in this PR since Add integer attribute of particle #348 will update the IC. The latest IC in Add integer attribute of particle #348 is on GAMER ythub now.