FDM Zoom-in simulation

[jchan192]

• Updated src/TestProblem/ELBDM/LSS/Init_TestProb_ELBDM_LSS.cpp
  to read a table of parameters to control the zoom-in volume

• Added a new example in example/test_problem/ELBDM/LSS_Hybrid_Zoomin/ for testing a smaller zoom-in simulation,
  while including the IC that can produce the results in (Chan+24, submitted to MNRAS).

[ChunYen-Chen]

Hi @jchan192, I left some comments.

Major comments

• The comments with [Bug] or [Potential bug] need to be fix.
• The comments with [Style] need to be updated to gamer style.
• Please remove all the trailing spaces. You can search them by this command:

grep -r -n "[[:blank:]]$" ./

Minor comments

• The comments with [Optimize] are some optimization or generalization of the code. Let me know if you disagree any of them.

The rest of the comments without tags are some minor change suggestions or requests.

Please let me know if any of my comments is unclear.

Once all of the conversations are resolved, I will try to reproduce your production run.

[ChunYen-Chen]

@jchan192 Thanks for the update. Please update the code according to the comments. The guideline of the comments is the same as the previous review.

[ChunYen-Chen]

@jchan192 Thanks for the update. Please update the code according to the comments. The guideline of the comments is the same as the previous review.

[ChunYen-Chen]

@jchan192
Could you update the download link of the Zoomin_IC_heavyhalo.tar.gz and Zoomin_IC_lighthalo.tar.gz according to gamer-project#390? I have uploaded Zoomin_IC_heavyhalo.tar.gz and Zoomin_IC_lighthalo.tar.gz to ythub. The link to Zoomin_IC_heavyhalo.tar.gz is

https://hub.yt/api/v1/item/677ce3a3999605c485c8de88/download

, and the link to Zoomin_IC_lighthalo.tar.gz is

https://hub.yt/api/v1/item/677cbeb4999605c485c8de7a/download

Examples of the download script:

#!/bin/bash

LOCAL_FILENAME="Zoomin_IC_heavyhalo"
FILE_ID="677cc1c3999605c485c8de80"

# 1. download
curl https://hub.yt/api/v1/item/${FILE_ID}/download -o "${LOCAL_FILENAME}.tar.gz"

# 2. unzip
tar zxvf ${LOCAL_FILENAME}.tar.gz
rm ${LOCAL_FILENAME}.tar.gz
ln -fs UM_IC_hybrid_N1024 UM_IC

#!/bin/bash

LOCAL_FILENAME="Zoomin_IC_lighthalo"
FILE_ID="677cbeb4999605c485c8de7a"

# 1. download
curl https://hub.yt/api/v1/item/${FILE_ID}/download -o "${LOCAL_FILENAME}.tar.gz"

# 2. unzip
tar zxvf ${LOCAL_FILENAME}.tar.gz
rm ${LOCAL_FILENAME}.tar.gz
ln -fs UM_IC_hybrid_N256_third UM_IC

See also gamer-project#408.