-
Notifications
You must be signed in to change notification settings - Fork 12
Add ELBDM/UniformGranule test problem #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: psidm
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I left some comments here.
example/test_problem/ELBDM/UniformGranule/Input__UM_IC_RefineRegion
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp
Outdated
Show resolved
Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/get_vel_dispersion.py
Outdated
Show resolved
Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/plot_correlation.py
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp
Outdated
Show resolved
Hide resolved
vivi235711
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I left some comment here.
Because I'm not familiar with the correlation function, could you please share the reference about how to calculate it? I confused why divided by std^2 or mean^2.
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp
Outdated
Show resolved
Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/get_vel_dispersion.py
Show resolved
Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/plot_correlation.py
Show resolved
Hide resolved
vivi235711
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have one minor comment.
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp
Outdated
Show resolved
Hide resolved
|
@HsunYeong An example of the download script: #!/bin/bash
LOCAL_FILENAME="uniform-granule"
FILE_ID="677cc1c3999605c485c8de80"
# 1. download
curl https://hub.yt/api/v1/item/${FILE_ID}/download -o "${LOCAL_FILENAME}.tar.gz"
# 2. unzip
tar -zxvf ${LOCAL_FILENAME}.tar.gz
rm ${LOCAL_FILENAME}.tar.gzSee also gamer-project#408. |
hyschive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HsunYeong Thanks for the contribution! I've added some comments, mostly regarding wording and formatting.
The only major suggestion is to file a separate PR to add support for computing standard deviation in Aux_ComputeProfile.cpp.
Additionally, please merge the latest psidm branch.
Add a test problem to simulate periodic box with homogeneous FDM granule initial condition.