Skip to content

Conversation

@HsunYeong
Copy link

Add a test problem to simulate periodic box with homogeneous FDM granule initial condition.

Copy link
Collaborator

@vivi235711 vivi235711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left some comments here.

Copy link
Collaborator

@vivi235711 vivi235711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I left some comment here.
Because I'm not familiar with the correlation function, could you please share the reference about how to calculate it? I confused why divided by std^2 or mean^2.

Copy link
Collaborator

@vivi235711 vivi235711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one minor comment.

@ChunYen-Chen
Copy link
Collaborator

ChunYen-Chen commented Jan 8, 2025

@HsunYeong
Could you update the download link of the uniform-granule.tar.gz according to gamer-project#390? I have uploaded uniform-granule.tar.gz to ythub. The link to uniform-granule.tar.gz is

https://hub.yt/api/v1/item/677cc1c3999605c485c8de80/download

An example of the download script:

#!/bin/bash

LOCAL_FILENAME="uniform-granule"
FILE_ID="677cc1c3999605c485c8de80"

# 1. download
curl https://hub.yt/api/v1/item/${FILE_ID}/download -o "${LOCAL_FILENAME}.tar.gz"

# 2. unzip
tar -zxvf ${LOCAL_FILENAME}.tar.gz
rm ${LOCAL_FILENAME}.tar.gz

See also gamer-project#408.

Copy link
Owner

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HsunYeong Thanks for the contribution! I've added some comments, mostly regarding wording and formatting.

The only major suggestion is to file a separate PR to add support for computing standard deviation in Aux_ComputeProfile.cpp.

Additionally, please merge the latest psidm branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

psidm Wave dark matter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants