Overhauled Angle-based Camera system #648
Open
AL2009man wants to merge 19 commits intofgsfdsfgs:portfrom
Open
Conversation
This PR overhauls the entire Camera system to better allow for future input methods like Gyro and Flick Stick, alongside decoupling Mouse Crosshair Speed out of Mouse Camera Speed, making the Crosshair Mouse be independent.
to equalize the swiveling between Horts/Verts crosshair swivel for mouse input: the swivel has been reduced to 20%
fgsfdsfgs
reviewed
Aug 23, 2025
moved the input-specific layer over to bmove directly, this means the original function has been removed
moved the original scaling from bmove over to input.c, while addressing issues with CamSpy and Hoverbike sensitivity. the latter now has customized scaling solution specific the `inputMouseGetScaledDeltaCrosshair` has been restored due to a specific bug with overall camera scaling after fixing CamSpy and Hoverbike, but itt'll be temporary, depending on the next commit fix?
redid the migration, now it should work without any conflictions
Author
|
as requested: I already went thru a initial phase of testing. Right now: the SpyCam and Hoverbike bug should be fixed. As a reminder: the overhauled camera system only applies to Mouse Camera (since it's used as a basis), Classic Joystick should remained the same as before. however: a few things that might need advanced testings, the first two is where i can't directly test it myself.
|
revised the entire crosshair swivel system to be closer to the original setup. This also fixes a problem with the crosshair not working as intended.
…d swaying at high sensitivity fixed a regression where the clamped swaying was missing, while restoring mixed input-based crosshair sway
cleaned up AngleCamera to make it a bit easier to manage and easily add or remove Camera-related inputs. also, a experimental fix to netplay/demo compatibility-- but it's hasn't really been tested outside of initial gameplay-based cutscenes
…rdless of Joystick Crosshair state Noticed some parts of the code was removed by accident, but that should be restored to how it originally was. Additionally: inorder to retain the sensitivity-tied fix: movedata.freelookdx/y has been replaced with `inputMouseGetRawDelta`'s equiavlent, although: that one's a workaround for the time being
Inorder to make PR reviewing easier, the crosshair decouple has been removed. To compensate: there's now a internal negative multiplayer for crosshair to compensate
AL2009man
changed the title
Author
|
as per request: the Crosshair Aim portion has been moved to #676, as I finally managed to solve a specific issue. now, there's a "negative multiplier" on the Mouse Crosshair Aiming as a workaround until that PR gets merged. |
This reverts commit 2348fff.
…angle unlike the previous method: this one directly use the engine's angle camera. (this is also a squash merge test)
AL2009man
force-pushed
the
PerfectQuakeDark3
branch
from
e02ee27 to
908de2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a two-part PR, the Overhauled Camera System, and the Decoupled Crosshair Mouse sensitivity. Originally planned to make it separate, but due to issues specific to Crosshair Camera, this PR merged both into one.To prepare for Flick Stick support: I went ahead and basically overhaul the entire camera system to be based on 360-degree rotational/angle system, this should improve general camera controlling system when using Mouse and be more friendly towards custom Reset Camera macros like SteamInput. It also prepares for future Input devices like Gyro Aiming (#644) and Flick Stick
This also features improvements to Crosshair Aiming, to make it more preciser-- even closer to raw movement!