Open
Conversation
Solves a issue when using Input Remapper's Mouse-based Reset to Horizon camera function (e.g. Steam Input), where the recenter couldn't stay centered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during the work on #648, i accidentally discovered a solution to the Reset Camera function when using SteamInput's Reset Camera function, or any other Input Remapper that has a similar function.
for context: Steam Input has the ability to assign a Reset Camera (referred as "Reset to Horizon") to any game to mimick a similar functionality, assuming the Angle Calibration is already done in advance. Unfortunately, if a game decides to put a 90 degree clamp limit: then it will not work as intended.
here's the bug in action:
compressO-perfectdarkangleclampfixbefore.mp4
This PR attempts to remedy this situation by removing the clamp limit entirely.
compressO-perfectdarkangleclampfixafter.mp4
While the bug can still persist when in a specific vertical angle, it should be lessen. This should at least have Input Remapper-based Reset Camera function to play nicely within the confines of the Mouse Input.
For Steam Input players: This will serve as a substitute until #682 gets added in.