[23819] Send heartbeat when wait_for_all_acked is called (backport #6098) #6102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
MiguelCompany
approved these changes
Oct 16, 2025
Contributor
Author
Contributor
|
@Mergifyio rebase |
* Refs #23798. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #23798. Send heartbeat when wait_for_all_acked is called. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit db8f527)
Contributor
Author
✅ Branch has been successfully rebased |
cferreiragonz
force-pushed
the
mergify/bp/3.3.x/pr-6098
branch
from
57ae3c1 to
337190c
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
cferreiragonz
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the user experience when explicitly expecting acknowledgement of samples on a DataWriter.
Instead of waiting for the periodic heartbeat event to occur, it directly triggers a heartbeat from
wait_for_all_ackedwhen necessary.@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6098 done by [Mergify](https://mergify.com).