Skip to content

[23819] Send heartbeat when wait_for_all_acked is called #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

[23819] Send heartbeat when wait_for_all_acked is called #6098

merged 2 commits into from
Oct 16, 2025

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 14, 2025 •
edited by cferreiragonz
Loading

Description

This improves the user experience when explicitly expecting acknowledgement of samples on a DataWriter.
Instead of waiting for the periodic heartbeat event to occur, it directly triggers a heartbeat from wait_for_all_acked when necessary.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #23798. Add test.
c2ab440 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany added this to the v3.4.1 milestone Oct 14, 2025
@MiguelCompany MiguelCompany mentioned this pull request Oct 14, 2025
Closed
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 14, 2025
schil227
schil227 reviewed Oct 14, 2025
View reviewed changes
cferreiragonz
cferreiragonz previously approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for ef1ee1b.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

fujitatomoya
fujitatomoya approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiguelCompany thanks for the fix 👍

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 16, 2025
@MiguelCompany MiguelCompany merged commit db8f527 into master Oct 16, 2025
25 of 28 checks passed
@MiguelCompany MiguelCompany deleted the feature/23798 branch October 16, 2025 05:55
@MiguelCompany
Copy link
Member Author

MiguelCompany commented Oct 16, 2025

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2025 •
edited
Loading

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 16, 2025
@MiguelCompany @mergify
Send heartbeat when wait_for_all_acked is called (#6098)
57ae3c1 
* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)
@mergify mergify bot mentioned this pull request Oct 16, 2025
Merged
12 tasks
mergify bot pushed a commit that referenced this pull request Oct 16, 2025
@MiguelCompany @mergify
Send heartbeat when wait_for_all_acked is called (#6098)
fb2c858 
* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)
@mergify mergify bot mentioned this pull request Oct 16, 2025
Merged
12 tasks
mergify bot pushed a commit that referenced this pull request Oct 16, 2025
@MiguelCompany @mergify
Send heartbeat when wait_for_all_acked is called (#6098)
98ac149 
* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)
@mergify mergify bot mentioned this pull request Oct 16, 2025
Merged
12 tasks
juanlofer-eprosima pushed a commit that referenced this pull request Oct 16, 2025
@MiguelCompany @juanlofer-eprosima
Send heartbeat when wait_for_all_acked is called (#6098)
8e38864 
* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)
MiguelCompany added a commit that referenced this pull request Oct 16, 2025
@mergify @MiguelCompany
Send heartbeat when wait_for_all_acked is called (#6098) (#6104)
c22c6d4 
* Refs #23798. Add test.



* Refs #23798. Send heartbeat when wait_for_all_acked is called.



---------


(cherry picked from commit db8f527)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Oct 17, 2025
@mergify @MiguelCompany @juanlofer-eprosima
Send heartbeat when wait_for_all_acked is called (#6098) (#6103)
f0cd0d7 
* Send heartbeat when wait_for_all_acked is called (#6098)

* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)

* Uncrustify

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Co-authored-by: Juan Lopez Fernandez <[email protected]>
cferreiragonz pushed a commit that referenced this pull request Nov 5, 2025
@MiguelCompany @cferreiragonz
Send heartbeat when wait_for_all_acked is called (#6098)
337190c 
* Refs #23798. Add test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23798. Send heartbeat when wait_for_all_acked is called.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit db8f527)
MiguelCompany added a commit that referenced this pull request Nov 6, 2025
@mergify @MiguelCompany
Send heartbeat when wait_for_all_acked is called (#6098) (#6102)
8d7dd00 
* Refs #23798. Add test.



* Refs #23798. Send heartbeat when wait_for_all_acked is called.



---------


(cherry picked from commit db8f527)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

+2 more reviewers

@schil227 schil227 schil227 left review comments

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.4.1 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

5 participants

@MiguelCompany @schil227 @fujitatomoya @cferreiragonz