Skip to content

[StyleCleanUp] Addressing SA warnings Part 2 #10123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 30, 2024

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Nov 27, 2024

Description

This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.

The current changes addresses the following Errors/Warnings in the src folder of WPF:

  • SA1206: The keywords within the declaration of an element should follow a standard ordering scheme
  • SA1513: Closing brace should be followed by blank line
  • SA1518: Code should not contain blank lines at the end of the file
  • SA1508: A closing brace should not be preceded by a blank line
  • SA1507: Code should not contain multiple blank lines in a row
  • SA1505: An opening brace should not be followed by a blank line
  • SA1500: Braces for multi-line statements should not share line

A good way to go about reviewing this is to go commit by commit which pans over individual errors/warnings, and hence easing out the overall understanding. For the error SA1513, there are two sets of changes, and going through the later one first will possibly give a clearer idea.

Customer Impact

None

Regression

None

Testing

Local Build Pass
The current set of changes looks fairly mechanical and probably don't need a Test Pass, but these set of PRs can be clubbed to do so at a later stage.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 requested review from a team as code owners November 27, 2024 08:32
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 27, 2024
himgoyalmicro
himgoyalmicro previously approved these changes Dec 9, 2024
Copy link
Contributor

@himgoyalmicro himgoyalmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harshit7962 harshit7962 merged commit 5363688 into dotnet:main Dec 30, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants