[StyleCleanUp] Addressing SA warnings (#10123)

* Update: Resolve SA1206 in src
* Update: Resolve SA1513 in src
* Update: Resolve SA1518 in src
* Update: Resolve SA1508 in src
* Update: Resolve SA1507 in src
* Update: Resolve SA1505 in src
* Update: Resolve SA1500 in src

Author: harshit7962

src/Microsoft.DotNet.Wpf/src/.editorconfig

@@ -311,30 +311,9 @@ dotnet_diagnostic.SA1121.severity = suggestion
 # SA1129: Do not use default value type constructor
 dotnet_diagnostic.SA1129.severity = suggestion
 
-# SA1206: Keyword ordering
-dotnet_diagnostic.SA1206.severity = suggestion
-
 # SA1400: Member should declare an access modifier
 dotnet_diagnostic.SA1400.severity = suggestion
 
-# SA1500: Braces for multi-line statements should not share line
-dotnet_diagnostic.SA1500.severity = suggestion
-
-# SA1505: An opening brace should not be followed by a blank line
-dotnet_diagnostic.SA1505.severity = suggestion
-
-# SA1507: Code should not contain multiple blank lines in a row
-dotnet_diagnostic.SA1507.severity = suggestion
-
-# SA1508: A closing brace should not be preceded by a blank line
-dotnet_diagnostic.SA1508.severity = suggestion
-
-# SA1513: Closing brace should be followed by blank line
-dotnet_diagnostic.SA1513.severity = suggestion
-
-# SA1518: Code should not contain blank lines at the end of the file
-dotnet_diagnostic.SA1518.severity = suggestion
-
 # SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
 dotnet_diagnostic.SYSLIB1045.severity = suggestion
 

src/Microsoft.DotNet.Wpf/src/Shared/MS/Internal/SafeSecurityHelper.cs

@@ -151,6 +151,7 @@ internal static Assembly GetLoadedAssembly(AssemblyName assemblyName)
                     return assemblies[i];
                 }
             }
+
             return null;
         }
 
@@ -171,6 +172,7 @@ static AssemblyName GetAssemblyName(Assembly assembly)
                         return result;
                     }
 	            }
+
                 //
                 // We use AssemblyName ctor here because GetName demands FileIOPermission
                 // and does load more than just the required information.
@@ -185,6 +187,7 @@ static AssemblyName GetAssemblyName(Assembly assembly)
                     GCNotificationToken.RegisterCallback(_cleanupCollectedAssemblies, null);
                     _isGCCallbackPending  = true;
                 }
+
                 return result;
             }
         }
@@ -203,6 +206,7 @@ static void CleanupCollectedAssemblies(object state) // dummy parameter required
                     {
                         continue;
                     }
+
                     if (weakRef.IsAlive)
                     {
                         // There is a weak ref that is still alive, register another GC callback for next time
@@ -215,16 +219,19 @@ static void CleanupCollectedAssemblies(object state) // dummy parameter required
                         {
                             keysToRemove = new List<object>();
                         }
+
                         keysToRemove.Add(key);
                     }
                 }
+
                 if (keysToRemove is not null)
                 {
                     foreach (object key in keysToRemove)
                     {
                         _assemblies.Remove(key);
                     }
                 }
+
                 if (foundLiveDynamicAssemblies)
                 {
                     GCNotificationToken.RegisterCallback(_cleanupCollectedAssemblies, null);
@@ -311,6 +318,7 @@ public override bool Equals(object o)
                     return (target1 == target2);
                 }
             }
+
             return base.Equals(o);
         }
 
@@ -320,6 +328,7 @@ public override bool Equals(object o)
             {
                 return object.ReferenceEquals(right, null);
             }
+
             return left.Equals(right);
         }
 

src/Microsoft.DotNet.Wpf/src/Shared/MS/Internal/Xaml/Context/XamlContextStack.cs

@@ -47,10 +47,12 @@ public XamlContextStack(XamlContextStack<T> source, bool copy)
                     {
                         _currentFrame = newFrame;
                     }
+
                     if (lastFrameInNewStack is not null)
                     {
                         lastFrameInNewStack.Previous = newFrame;
                     }
+
                     lastFrameInNewStack = newFrame;
                     iteratorFrame = (T)iteratorFrame.Previous;
                 }
@@ -88,6 +90,7 @@ public T GetFrame(int depth)
             {
                 iteratorFrame = (T)iteratorFrame.Previous;
             }
+
             return iteratorFrame;
         }
 
@@ -106,6 +109,7 @@ public void PushScope()
                 _recycledFrame = (T)_recycledFrame.Previous;
                 _currentFrame.Previous = lastFrame;
             }
+
             _depth++;
             Debug.Assert(CurrentFrame.Depth == Depth);
         }

src/Microsoft.DotNet.Wpf/src/Shared/MS/Internal/Xaml/Parser/SpecialBracketCharacters.cs

@@ -21,7 +21,7 @@ internal class SpecialBracketCharacters : ISupportInitialize
     {
         private string _startChars;
         private string _endChars;
-        private readonly static ISet<char> _restrictedCharSet = new SortedSet<char>((new char[] { '=', ',', '\'', '"', '{', '}', '\\' }));
+        private static readonly ISet<char> _restrictedCharSet = new SortedSet<char>((new char[] { '=', ',', '\'', '"', '{', '}', '\\' }));
         private bool _initializing;
         private StringBuilder _startCharactersStringBuilder;
         private StringBuilder _endCharactersStringBuilder;