Merge branch 'main' into editorconfigCleanup2

harshit7962 · harshit7962 · commit fdf4b83bc78d · 2024-12-30T14:29:29.000+05:30
diff --git a/src/Microsoft.DotNet.Wpf/src/.editorconfig b/src/Microsoft.DotNet.Wpf/src/.editorconfig
@@ -311,18 +311,9 @@ dotnet_diagnostic.SA1121.severity = suggestion
 # SA1129: Do not use default value type constructor
 dotnet_diagnostic.SA1129.severity = suggestion
 
-# SA1131: Constant values should appear on the right-hand side of comparisons
-dotnet_diagnostic.SA1131.severity = suggestion
-
 # SA1400: Member should declare an access modifier
 dotnet_diagnostic.SA1400.severity = suggestion
 
-# SA1404: Code analysis suppression should have justification
-dotnet_diagnostic.SA1404.severity = suggestion
-
-# SA1408: Conditional expressions should declare precedence
-dotnet_diagnostic.SA1408.severity = suggestion
-
 # SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
 dotnet_diagnostic.SYSLIB1045.severity = suggestion
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Context/ObjectWriterContext.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Context/ObjectWriterContext.cs
@@ -173,7 +173,7 @@ internal XamlType ServiceProvider_ResolveXamlType(string qName)
 
         internal AmbientPropertyValue ServiceProvider_GetFirstAmbientValue(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)
         {
-            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /*searchLiveStackOnly*/false, /*types*/null, properties, true);
+            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, true);
             return (valueList.Count == 0) ? null : valueList[0];
         }
 
@@ -185,7 +185,7 @@ internal object ServiceProvider_GetFirstAmbientValue(XamlType[] types)
 
         internal IEnumerable<AmbientPropertyValue> ServiceProvider_GetAllAmbientValues(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)
         {
-            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /*searchLiveStackOnly*/false, /*types*/null, properties, /*stopAfterFirst*/ false);
+            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, stopAfterFirst: false);
             return valueList;
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlObjectWriter.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlObjectWriter.cs
@@ -131,7 +131,7 @@ private XamlRuntime CreateRuntime(XamlObjectWriterSettings settings, XamlSchemaC
 
             if (result is null)
             {
-                result = new ClrObjectRuntime(runtimeSettings, true /*isWriter*/);
+                result = new ClrObjectRuntime(runtimeSettings, isWriter: true);
             }
 
             result.LineInfo = this;
@@ -619,7 +619,7 @@ public override void WriteStartMember(XamlMember property)
 
             // Duplicate Property Setting Check.
             //
-            Logic_DuplicatePropertyCheck(_context, property, false /*onParent*/);
+            Logic_DuplicatePropertyCheck(_context, property, onParent: false);
 
             // If we haven't created the object yet then consider creating it now.
             // We need an object instance to set property values on.
@@ -1573,7 +1573,7 @@ private void Logic_ApplyCurrentPreconstructionPropertyValues(ObjectWriterContext
                     }
                     else
                     {
-                        Logic_ApplyPropertyValue(ctx, prop, value, false /*onParent*/);
+                        Logic_ApplyPropertyValue(ctx, prop, value, onParent: false);
                     }
                 }
             }
@@ -2072,7 +2072,7 @@ private void Logic_DoAssignmentToParentProperty(ObjectWriterContext ctx)
 
                         if (!ctx.CurrentIsObjectFromMember)
                         {
-                            Logic_ApplyPropertyValue(ctx, parentProperty, value, true /*onParent*/);
+                            Logic_ApplyPropertyValue(ctx, parentProperty, value, onParent: true);
 
                             // registered a named object
                             if (parentProperty == parentType.GetAliasedProperty(XamlLanguage.Name))
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlTextReader.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlTextReader.cs
@@ -111,7 +111,7 @@ private void Initialize(XmlReader givenXmlReader, XamlSchemaContext schemaContex
             _endOfStreamNode = new InternalNode(InternalNodeType.EndOfStream);
 
             _context = (XamlParserContext)XamlContext.CreateContext(UsageMode.Parser, schemaContext,
-                                                            _mergedSettings.LocalAssembly, false /*ignoreCanConvert*/);
+                                                            _mergedSettings.LocalAssembly, ignoreCanConvert: false);
 
             XamlScanner xamlScanner = new XamlScanner(_context, myXmlReader, _mergedSettings);
             XamlPullParser parser = new XamlPullParser(_context, xamlScanner, _mergedSettings);
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/MeScanner.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/MeScanner.cs
@@ -327,15 +327,15 @@ private void ResolvePropertyName(string longName)
 
             if (propName.IsDotted)
             {
-                prop = _context.GetDottedProperty(tagType, tagNamespace, propName, false /*tagIsRoot*/);
+                prop = _context.GetDottedProperty(tagType, tagNamespace, propName, tagIsRoot: false);
             }
 
             // Regular property p
             else
             {
                 string ns = _context.GetAttributeNamespace(propName, Namespace);
                 declaringType = _context.CurrentType;
-                prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, false /*tagIsRoot*/);
+                prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, tagIsRoot: false);
             }
 
             _tokenProperty = prop;
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/XamlAttribute.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/XamlAttribute.cs
@@ -153,7 +153,7 @@ private XamlMember GetXamlAttributeProperty(XamlParserContext context, XamlPrope
                 if (propName.IsDotted)
                 {
                     XamlType attachedOwnerType = new XamlType(string.Empty, propName.OwnerName, null, context.SchemaContext);
-                    unknownProperty = new XamlMember(propName.Name, attachedOwnerType, true /*isAttachable*/);
+                    unknownProperty = new XamlMember(propName.Name, attachedOwnerType, isAttachable: true);
                 }
                 else
                 {
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/DynamicMethodRuntime.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/DynamicMethodRuntime.cs
@@ -126,15 +126,15 @@ private Dictionary<Type, DelegateCreator> DelegateCreators
 
         internal DynamicMethodRuntime(XamlRuntimeSettings settings, XamlSchemaContext schemaContext,
             XamlAccessLevel accessLevel)
-            : base(settings, true /*isWriter*/)
+            : base(settings, isWriter: true)
         {
             Debug.Assert(schemaContext is not null);
             Debug.Assert(accessLevel is not null);
             _schemaContext = schemaContext;
             _localAssembly = Assembly.Load(accessLevel.AssemblyAccessToAssemblyName);
             if (accessLevel.PrivateAccessToTypeName is not null)
             {
-                _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, true /*throwOnError*/);
+                _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, throwOnError: true);
             }
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/PartialTrustTolerantRuntime.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/PartialTrustTolerantRuntime.cs
@@ -37,7 +37,7 @@ class PartialTrustTolerantRuntime : XamlRuntime
 
         public PartialTrustTolerantRuntime(XamlRuntimeSettings runtimeSettings, XamlAccessLevel accessLevel, XamlSchemaContext schemaContext)
         {
-            _transparentRuntime = new ClrObjectRuntime(runtimeSettings, true /*isWriter*/);
+            _transparentRuntime = new ClrObjectRuntime(runtimeSettings, isWriter: true);
             _accessLevel = accessLevel;
             _schemaContext = schemaContext;
         }
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/CollectionReflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/CollectionReflector.cs
@@ -67,12 +67,12 @@ internal static XamlCollectionKind LookupCollectionKind(Type type, out MethodInf
             }
 
             // If the type doesn't match any of the interfaces, check for Add methods
-            if (TryGetDictionaryAdder(type, false /*mayBeIDictionary*/, out addMethod))
+            if (TryGetDictionaryAdder(type, mayBeIDictionary: false, out addMethod))
             {
                 return XamlCollectionKind.Dictionary;
             }
 
-            if (TryGetCollectionAdder(type, false /*mayBeICollection*/, out addMethod))
+            if (TryGetCollectionAdder(type, mayBeICollection: false, out addMethod))
             {
                 return XamlCollectionKind.Collection;
             }
@@ -86,15 +86,15 @@ internal static MethodInfo LookupAddMethod(Type type, XamlCollectionKind collect
             switch (collectionKind)
             {
                 case XamlCollectionKind.Collection:
-                    bool isCollection = TryGetCollectionAdder(type, true /*mayBeICollection*/, out result);
+                    bool isCollection = TryGetCollectionAdder(type, mayBeICollection: true, out result);
                     if (isCollection && result is null)
                     {
                         throw new XamlSchemaException(SR.Format(SR.AmbiguousCollectionItemType, type));
                     }
 
                     break;
                 case XamlCollectionKind.Dictionary:
-                    bool isDictionary = TryGetDictionaryAdder(type, true /*mayBeIDictionary*/, out result);
+                    bool isDictionary = TryGetDictionaryAdder(type, mayBeIDictionary: true, out result);
                     if (isDictionary && result is null)
                     {
                         throw new XamlSchemaException(SR.Format(SR.AmbiguousDictionaryItemType, type));
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/Reflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/Reflector.cs
@@ -67,7 +67,7 @@ public string GetAttributeString(Type attributeType, out bool checkedInherited)
                 // Passes inherit=true for reasons explained in comment on XamlType.TryGetAttributeString
                 checkedInherited = true;
 
-                object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, true /*inherit*/);
+                object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, inherit: true);
                 if (attributes.Length == 0)
                 {
                     return null;
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs
@@ -782,23 +782,23 @@ private List<MethodInfo> LookupStaticAdders(string name)
             string adderName = KnownStrings.Add + name + KnownStrings.Handler;
             MemberInfo[] adders = UnderlyingType.GetMember(adderName, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredAdders, otherAdders;
-            PrioritizeAccessors(adders, true /*isEvent*/, false /*isGetter*/, out preferredAdders, out otherAdders);
+            PrioritizeAccessors(adders, isEvent: true, isGetter: false, out preferredAdders, out otherAdders);
             return preferredAdders ?? otherAdders;
         }
 
         private List<MethodInfo> LookupStaticGetters(string name)
         {
             MemberInfo[] getters = UnderlyingType.GetMember(KnownStrings.Get + name, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredGetters, otherGetters;
-            PrioritizeAccessors(getters, false /*isEvent*/, true /*isGetter*/, out preferredGetters, out otherGetters);
+            PrioritizeAccessors(getters, isEvent: false, isGetter: true, out preferredGetters, out otherGetters);
             return preferredGetters ?? otherGetters;
         }
 
         private List<MethodInfo> LookupStaticSetters(string name)
         {
             MemberInfo[] setters = UnderlyingType.GetMember(KnownStrings.Set + name, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredSetters, otherSetters;
-            PrioritizeAccessors(setters, false /*isEvent*/, false /*isGetter*/, out preferredSetters, out otherSetters);
+            PrioritizeAccessors(setters, isEvent: false, isGetter: false, out preferredSetters, out otherSetters);
             return preferredSetters ?? otherSetters;
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/XmlNamespace.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/XmlNamespace.cs
@@ -75,7 +75,7 @@ public override XamlProperty GetDirectiveProperty(string name)
             if (directive == null)
             {
                 directive = new UnknownProperty(name,
-                                                null, /*declaringType - xml directives don't have one. */
+                                                declaringType: null, /* xml directives don't have a declaring type. */
                                                 XmlDirectives.Uri);
             }
             return directive;
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlMember.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlMember.cs
@@ -45,7 +45,7 @@ public XamlMember(PropertyInfo propertyInfo, XamlSchemaContext schemaContext)
         }
 
         public XamlMember(PropertyInfo propertyInfo, XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            : this(propertyInfo, schemaContext, invoker, new MemberReflector(false /*isEvent*/))
+            : this(propertyInfo, schemaContext, invoker, new MemberReflector(isEvent: false))
         {
         }
 
@@ -68,7 +68,7 @@ public XamlMember(EventInfo eventInfo, XamlSchemaContext schemaContext)
         }
 
         public XamlMember(EventInfo eventInfo, XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            :this(eventInfo, schemaContext, invoker, new MemberReflector(true /*isEvent*/))
+            :this(eventInfo, schemaContext, invoker, new MemberReflector(isEvent: true))
         {
         }
 
@@ -93,7 +93,7 @@ public XamlMember(string attachablePropertyName, MethodInfo getter, MethodInfo s
 
         public XamlMember(string attachablePropertyName, MethodInfo getter, MethodInfo setter,
             XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            :this(attachablePropertyName, getter, setter, schemaContext, invoker, new MemberReflector(getter, setter, false /*isEvent*/))
+            :this(attachablePropertyName, getter, setter, schemaContext, invoker, new MemberReflector(getter, setter, isEvent: false))
         {
         }
 
@@ -127,7 +127,7 @@ public XamlMember(string attachableEventName, MethodInfo adder, XamlSchemaContex
 
         public XamlMember(string attachableEventName, MethodInfo adder, XamlSchemaContext schemaContext,
             XamlMemberInvoker invoker)
-            : this(attachableEventName, adder, schemaContext, invoker, new MemberReflector(null, adder, true /*isEvent*/))
+            : this(attachableEventName, adder, schemaContext, invoker, new MemberReflector(null, adder, isEvent: true))
         {
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlObjectReader.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlObjectReader.cs
@@ -534,7 +534,7 @@ public static MemberMarkupInfo ForProperty(
 
             static MemberMarkupInfo ForSequence(object source, XamlMember property, SerializerContext context, bool isAttachable)
             {
-                var itemsInfo = ForSequenceItems(source, isAttachable ? null : property, property.Type, context, false /*allowReadOnly*/);
+                var itemsInfo = ForSequenceItems(source, isAttachable ? null : property, property.Type, context, allowReadOnly: false);
                 if (itemsInfo is not null && itemsInfo.Children.Count != 0)
                 {
                     return new MemberMarkupInfo
@@ -1206,7 +1206,7 @@ void AddItemsProperty(object value, SerializerContext context, XamlType xamlType
                 }
                 else if (xamlType.IsCollection)
                 {
-                    propertyInfo = MemberMarkupInfo.ForSequenceItems(value, null, xamlType, context, true /*allowReadOnly*/);
+                    propertyInfo = MemberMarkupInfo.ForSequenceItems(value, null, xamlType, context, allowReadOnly: true);
                 }
 
                 if (propertyInfo is not null && propertyInfo.Children.Count != 0)
@@ -2512,7 +2512,7 @@ public SerializerContext(XamlSchemaContext schemaContext, XamlObjectReaderSettin
                 prefixToNamespaceMap = new Dictionary<string, string>();
                 ReferenceTable = new ReferenceTable(null);
                 this.schemaContext = schemaContext;
-                runtime = new ClrObjectRuntime(null, false /*isWriter*/);
+                runtime = new ClrObjectRuntime(null, isWriter: false);
                 this.settings = settings;
             }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs
@@ -353,7 +353,7 @@ public XamlMember GetMember(string name)
             XamlMember result;
             if (!_reflector.Members.TryGetValue(name, out result) && !_reflector.Members.IsComplete)
             {
-                result = LookupMember(name, false /*skipReadOnlyCheck*/);
+                result = LookupMember(name, skipReadOnlyCheck: false);
                 result = _reflector.Members.TryAdd(name, result);
             }
 
@@ -806,8 +806,8 @@ protected virtual XamlMember LookupContentProperty()
                 {
                     return null;
                 }
-
-                return GetPropertyOrUnknown(contentPropertyName, false /*skipReadOnlyCheck*/);
+                
+                return GetPropertyOrUnknown(contentPropertyName, skipReadOnlyCheck: false);
             }
 
             if (BaseType is not null)
@@ -1538,7 +1538,7 @@ private XamlMember GetPropertyOrUnknown(string propertyName, bool skipReadOnlyCh
             XamlMember result = skipReadOnlyCheck ? LookupMember(propertyName, true) : GetMember(propertyName);
             if (result is null)
             {
-                result = new XamlMember(propertyName, this /*declaringType*/, false /*isAttachable*/);
+                result = new XamlMember(propertyName, declaringType: this, isAttachable: false);
             }
 
             return result;

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ internal XamlType ServiceProvider_ResolveXamlType(string qName)`
`173`	`173`
`174`	`174`	`internal AmbientPropertyValue ServiceProvider_GetFirstAmbientValue(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)`
`175`	`175`	`{`
`176`		`- List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /searchLiveStackOnly/false, /types/null, properties, true);`
	`176`	`+ List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, true);`
`177`	`177`	`return (valueList.Count == 0) ? null : valueList[0];`
`178`	`178`	`}`
`179`	`179`
`@@ -185,7 +185,7 @@ internal object ServiceProvider_GetFirstAmbientValue(XamlType[] types)`
`185`	`185`
`186`	`186`	`internal IEnumerable<AmbientPropertyValue> ServiceProvider_GetAllAmbientValues(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)`
`187`	`187`	`{`
`188`		`- List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /searchLiveStackOnly/false, /types/null, properties, /stopAfterFirst/ false);`
	`188`	`+ List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, stopAfterFirst: false);`
`189`	`189`	`return valueList;`
`190`	`190`	`}`
`191`	`191`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ private XamlRuntime CreateRuntime(XamlObjectWriterSettings settings, XamlSchemaC`
`131`	`131`
`132`	`132`	`if (result is null)`
`133`	`133`	`{`
`134`		`- result = new ClrObjectRuntime(runtimeSettings, true /isWriter/);`
	`134`	`+ result = new ClrObjectRuntime(runtimeSettings, isWriter: true);`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`result.LineInfo = this;`
`@@ -619,7 +619,7 @@ public override void WriteStartMember(XamlMember property)`
`619`	`619`
`620`	`620`	`// Duplicate Property Setting Check.`
`621`	`621`	`//`
`622`		`- Logic_DuplicatePropertyCheck(_context, property, false /onParent/);`
	`622`	`+ Logic_DuplicatePropertyCheck(_context, property, onParent: false);`
`623`	`623`
`624`	`624`	`// If we haven't created the object yet then consider creating it now.`
`625`	`625`	`// We need an object instance to set property values on.`
`@@ -1573,7 +1573,7 @@ private void Logic_ApplyCurrentPreconstructionPropertyValues(ObjectWriterContext`
`1573`	`1573`	`}`
`1574`	`1574`	`else`
`1575`	`1575`	`{`
`1576`		`- Logic_ApplyPropertyValue(ctx, prop, value, false /onParent/);`
	`1576`	`+ Logic_ApplyPropertyValue(ctx, prop, value, onParent: false);`
`1577`	`1577`	`}`
`1578`	`1578`	`}`
`1579`	`1579`	`}`
`@@ -2072,7 +2072,7 @@ private void Logic_DoAssignmentToParentProperty(ObjectWriterContext ctx)`
`2072`	`2072`
`2073`	`2073`	`if (!ctx.CurrentIsObjectFromMember)`
`2074`	`2074`	`{`
`2075`		`- Logic_ApplyPropertyValue(ctx, parentProperty, value, true /onParent/);`
	`2075`	`+ Logic_ApplyPropertyValue(ctx, parentProperty, value, onParent: true);`
`2076`	`2076`
`2077`	`2077`	`// registered a named object`
`2078`	`2078`	`if (parentProperty == parentType.GetAliasedProperty(XamlLanguage.Name))`
Original file line number	Diff line number	Diff line change
`@@ -327,15 +327,15 @@ private void ResolvePropertyName(string longName)`
`327`	`327`
`328`	`328`	`if (propName.IsDotted)`
`329`	`329`	`{`
`330`		`- prop = _context.GetDottedProperty(tagType, tagNamespace, propName, false /tagIsRoot/);`
	`330`	`+ prop = _context.GetDottedProperty(tagType, tagNamespace, propName, tagIsRoot: false);`
`331`	`331`	`}`
`332`	`332`
`333`	`333`	`// Regular property p`
`334`	`334`	`else`
`335`	`335`	`{`
`336`	`336`	`string ns = _context.GetAttributeNamespace(propName, Namespace);`
`337`	`337`	`declaringType = _context.CurrentType;`
`338`		`- prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, false /tagIsRoot/);`
	`338`	`+ prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, tagIsRoot: false);`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`_tokenProperty = prop;`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ private XamlMember GetXamlAttributeProperty(XamlParserContext context, XamlPrope`
`153`	`153`	`if (propName.IsDotted)`
`154`	`154`	`{`
`155`	`155`	`XamlType attachedOwnerType = new XamlType(string.Empty, propName.OwnerName, null, context.SchemaContext);`
`156`		`- unknownProperty = new XamlMember(propName.Name, attachedOwnerType, true /isAttachable/);`
	`156`	`+ unknownProperty = new XamlMember(propName.Name, attachedOwnerType, isAttachable: true);`
`157`	`157`	`}`
`158`	`158`	`else`
`159`	`159`	`{`
Original file line number	Diff line number	Diff line change
`@@ -126,15 +126,15 @@ private Dictionary<Type, DelegateCreator> DelegateCreators`
`126`	`126`
`127`	`127`	`internal DynamicMethodRuntime(XamlRuntimeSettings settings, XamlSchemaContext schemaContext,`
`128`	`128`	`XamlAccessLevel accessLevel)`
`129`		`- : base(settings, true /isWriter/)`
	`129`	`+ : base(settings, isWriter: true)`
`130`	`130`	`{`
`131`	`131`	`Debug.Assert(schemaContext is not null);`
`132`	`132`	`Debug.Assert(accessLevel is not null);`
`133`	`133`	`_schemaContext = schemaContext;`
`134`	`134`	`_localAssembly = Assembly.Load(accessLevel.AssemblyAccessToAssemblyName);`
`135`	`135`	`if (accessLevel.PrivateAccessToTypeName is not null)`
`136`	`136`	`{`
`137`		`- _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, true /throwOnError/);`
	`137`	`+ _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, throwOnError: true);`
`138`	`138`	`}`
`139`	`139`	`}`
`140`	`140`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class PartialTrustTolerantRuntime : XamlRuntime`
`37`	`37`
`38`	`38`	`public PartialTrustTolerantRuntime(XamlRuntimeSettings runtimeSettings, XamlAccessLevel accessLevel, XamlSchemaContext schemaContext)`
`39`	`39`	`{`
`40`		`- _transparentRuntime = new ClrObjectRuntime(runtimeSettings, true /isWriter/);`
	`40`	`+ _transparentRuntime = new ClrObjectRuntime(runtimeSettings, isWriter: true);`
`41`	`41`	`_accessLevel = accessLevel;`
`42`	`42`	`_schemaContext = schemaContext;`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,12 @@ internal static XamlCollectionKind LookupCollectionKind(Type type, out MethodInf`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// If the type doesn't match any of the interfaces, check for Add methods`
`70`		`- if (TryGetDictionaryAdder(type, false /mayBeIDictionary/, out addMethod))`
	`70`	`+ if (TryGetDictionaryAdder(type, mayBeIDictionary: false, out addMethod))`
`71`	`71`	`{`
`72`	`72`	`return XamlCollectionKind.Dictionary;`
`73`	`73`	`}`
`74`	`74`
`75`		`- if (TryGetCollectionAdder(type, false /mayBeICollection/, out addMethod))`
	`75`	`+ if (TryGetCollectionAdder(type, mayBeICollection: false, out addMethod))`
`76`	`76`	`{`
`77`	`77`	`return XamlCollectionKind.Collection;`
`78`	`78`	`}`
`@@ -86,15 +86,15 @@ internal static MethodInfo LookupAddMethod(Type type, XamlCollectionKind collect`
`86`	`86`	`switch (collectionKind)`
`87`	`87`	`{`
`88`	`88`	`case XamlCollectionKind.Collection:`
`89`		`- bool isCollection = TryGetCollectionAdder(type, true /mayBeICollection/, out result);`
	`89`	`+ bool isCollection = TryGetCollectionAdder(type, mayBeICollection: true, out result);`
`90`	`90`	`if (isCollection && result is null)`
`91`	`91`	`{`
`92`	`92`	`throw new XamlSchemaException(SR.Format(SR.AmbiguousCollectionItemType, type));`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`break;`
`96`	`96`	`case XamlCollectionKind.Dictionary:`
`97`		`- bool isDictionary = TryGetDictionaryAdder(type, true /mayBeIDictionary/, out result);`
	`97`	`+ bool isDictionary = TryGetDictionaryAdder(type, mayBeIDictionary: true, out result);`
`98`	`98`	`if (isDictionary && result is null)`
`99`	`99`	`{`
`100`	`100`	`throw new XamlSchemaException(SR.Format(SR.AmbiguousDictionaryItemType, type));`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public string GetAttributeString(Type attributeType, out bool checkedInherited)`
`67`	`67`	`// Passes inherit=true for reasons explained in comment on XamlType.TryGetAttributeString`
`68`	`68`	`checkedInherited = true;`
`69`	`69`
`70`		`- object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, true /inherit/);`
	`70`	`+ object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, inherit: true);`
`71`	`71`	`if (attributes.Length == 0)`
`72`	`72`	`{`
`73`	`73`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -782,23 +782,23 @@ private List<MethodInfo> LookupStaticAdders(string name)`
`782`	`782`	`string adderName = KnownStrings.Add + name + KnownStrings.Handler;`
`783`	`783`	`MemberInfo[] adders = UnderlyingType.GetMember(adderName, MemberTypes.Method, AttachableProperties_BF);`
`784`	`784`	`List<MethodInfo> preferredAdders, otherAdders;`
`785`		`- PrioritizeAccessors(adders, true /isEvent/, false /isGetter/, out preferredAdders, out otherAdders);`
	`785`	`+ PrioritizeAccessors(adders, isEvent: true, isGetter: false, out preferredAdders, out otherAdders);`
`786`	`786`	`return preferredAdders ?? otherAdders;`
`787`	`787`	`}`
`788`	`788`
`789`	`789`	`private List<MethodInfo> LookupStaticGetters(string name)`
`790`	`790`	`{`
`791`	`791`	`MemberInfo[] getters = UnderlyingType.GetMember(KnownStrings.Get + name, MemberTypes.Method, AttachableProperties_BF);`
`792`	`792`	`List<MethodInfo> preferredGetters, otherGetters;`
`793`		`- PrioritizeAccessors(getters, false /isEvent/, true /isGetter/, out preferredGetters, out otherGetters);`
	`793`	`+ PrioritizeAccessors(getters, isEvent: false, isGetter: true, out preferredGetters, out otherGetters);`
`794`	`794`	`return preferredGetters ?? otherGetters;`
`795`	`795`	`}`
`796`	`796`
`797`	`797`	`private List<MethodInfo> LookupStaticSetters(string name)`
`798`	`798`	`{`
`799`	`799`	`MemberInfo[] setters = UnderlyingType.GetMember(KnownStrings.Set + name, MemberTypes.Method, AttachableProperties_BF);`
`800`	`800`	`List<MethodInfo> preferredSetters, otherSetters;`
`801`		`- PrioritizeAccessors(setters, false /isEvent/, false /isGetter/, out preferredSetters, out otherSetters);`
	`801`	`+ PrioritizeAccessors(setters, isEvent: false, isGetter: false, out preferredSetters, out otherSetters);`
`802`	`802`	`return preferredSetters ?? otherSetters;`
`803`	`803`	`}`
`804`	`804`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public override XamlProperty GetDirectiveProperty(string name)`
`75`	`75`	`if (directive == null)`
`76`	`76`	`{`
`77`	`77`	`directive = new UnknownProperty(name,`
`78`		`- null, /declaringType - xml directives don't have one. /`
	`78`	`+ declaringType: null, /* xml directives don't have a declaring type. */`
`79`	`79`	`XmlDirectives.Uri);`
`80`	`80`	`}`
`81`	`81`	`return directive;`